From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4sbG-0005m9-Ja for qemu-devel@nongnu.org; Tue, 06 Mar 2012 06:30:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4sbA-0002ar-Ep for qemu-devel@nongnu.org; Tue, 06 Mar 2012 06:30:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4sbA-0002ad-6F for qemu-devel@nongnu.org; Tue, 06 Mar 2012 06:30:32 -0500 Date: Tue, 6 Mar 2012 08:30:31 -0300 From: Luiz Capitulino Message-ID: <20120306083031.1864a5ac@doriath.home> In-Reply-To: <4F5517A7.90207@redhat.com> References: <1330968842-24635-1-git-send-email-pbonzini@redhat.com> <1330968842-24635-6-git-send-email-pbonzini@redhat.com> <4F550C34.90005@redhat.com> <4F5517A7.90207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, fsimonce@redhat.com, Eric Blake , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Mon, 05 Mar 2012 20:44:39 +0100 Paolo Bonzini wrote: > Il 05/03/2012 19:55, Eric Blake ha scritto: > > Right now, libvirt has an API virDomainSnapshotCreateXML with a flag > > VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode > > operand. Am I guaranteed that if I pass a 'mode' argument of 'existing' > > to an older qemu that lacked mode, I will get a sane error? If so, then > > this rewrite looks fine from libvirt's point of view. > > Not sure... Luiz? The question is: will I get an error if I pass an unknown argument to a command? Yes, you will.