From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S4uUw-00030D-VU
	for qemu-devel@nongnu.org; Tue, 06 Mar 2012 08:32:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S4uUk-0002QP-8j
	for qemu-devel@nongnu.org; Tue, 06 Mar 2012 08:32:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17086)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S4uUj-0002Q3-Ve
	for qemu-devel@nongnu.org; Tue, 06 Mar 2012 08:32:02 -0500
Date: Tue, 6 Mar 2012 15:31:51 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120306133151.GD2240@garlic.redhat.com>
References: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>, Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Mar 02, 2012 at 04:49:44PM +0100, Hans de Goede wrote:

Ack. Anthony, this breaks build for libcacard, caused by my last commit
to the same file as Brad noted:

    commit 0082f4336e128a17d5f34e01de0fd29930e99b0d
    Author: Alon Levy <alevy@redhat.com>
    Date:   Sun Feb 26 17:09:24 2012 +0100

        libcacard: fix reported ATR length

Can you apply?

Thanks,
Alon

> VCARD_ATR_PREFIX is used as part of an array initializer so it should
> not have () around it, so far this happened to work, but gcc-4.7 does
> not like it.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  libcacard/vcardt.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d4d8e2e..d3e9522 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
>  #define MAX_CHANNEL 4
>  
>  /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> -                               'V', 'C', 'A', 'R', 'D', '_')
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> +                               'V', 'C', 'A', 'R', 'D', '_'
>  
>  
>  typedef enum {
> -- 
> 1.7.7.6
> 
>