From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4wW6-0007cU-Dn for qemu-devel@nongnu.org; Tue, 06 Mar 2012 10:41:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4wVw-0003np-IG for qemu-devel@nongnu.org; Tue, 06 Mar 2012 10:41:33 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:55508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4wVw-0003nh-9J for qemu-devel@nongnu.org; Tue, 06 Mar 2012 10:41:24 -0500 Received: by dajr28 with SMTP id r28so8143748daj.33 for ; Tue, 06 Mar 2012 07:41:22 -0800 (PST) Sender: fluxion Date: Tue, 6 Mar 2012 09:41:16 -0600 From: Michael Roth Message-ID: <20120306154116.GC3588@illuin> References: <4F562D14.809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F562D14.809@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: qemu-devel@nongnu.org On Tue, Mar 06, 2012 at 04:28:20PM +0100, Michal Privoznik wrote: > On 29.02.2012 17:02, Michal Privoznik wrote: > > This command returns an array of: > > > > [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] > > > > for each interface in the system. > > Currently, only IPv4 and IPv6 are supported. > > > > Signed-off-by: Michal Privoznik > > --- > > diff to v5: > > -another change of command > > diff to v4: > > -change return type > > > > diff to v3: > > -use ctpop32() instead of separate count_one_bits() > > > > diff to v2: > > -Properly set IP addr family for IPv6 > > > > diff to v1: > > -move from guest-getip to guest-network-info > > -replace black boxed algorithm for population count > > -several coding styles improvements > > > > qapi-schema-guest.json | 59 ++++++++++++++++ > > qga/commands-posix.c | 181 ++++++++++++++++++++++++++++++++++++++++++++++++ > > qga/commands-win32.c | 6 ++ > > 3 files changed, 246 insertions(+), 0 deletions(-) > > > > ping? Looks good other than a s/get-network-interfaces/network-get-interfaces, but I can fix that up. Have it queued for testing, should get to it today. > >