From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S54WH-0004W0-G9 for qemu-devel@nongnu.org; Tue, 06 Mar 2012 19:14:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S54WF-0005UQ-RB for qemu-devel@nongnu.org; Tue, 06 Mar 2012 19:14:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S54WF-0005UM-IZ for qemu-devel@nongnu.org; Tue, 06 Mar 2012 19:14:15 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q270EEVb012561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Mar 2012 19:14:14 -0500 From: Alex Williamson Date: Tue, 06 Mar 2012 17:14:13 -0700 Message-ID: <20120307001405.3079.50312.stgit@bling.home> In-Reply-To: <20120307000340.3079.87515.stgit@bling.home> References: <20120307000340.3079.87515.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 2/6] acpi_piix4: Only allow writes to PCI hotplug eject register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, ddutile@redhat.com, gleb@redhat.com, mst@redhat.com This is never read. We can also derive bus from the write handler, which later makes this easier to call directly. Note that pciej_write was actually called with (PCIBus *)dev->bus, which is cast as a void* allowing us to pretend it's a BusState*. Fix this so we don't depend on the BusState location within PCIBus. Signed-off-by: Alex Williamson --- hw/acpi_piix4.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 5960b7f..4d88e23 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -489,15 +489,11 @@ static uint32_t pci_updown_read(void *opaque, uint32_t addr) return val; } -static uint32_t pciej_read(void *opaque, uint32_t addr) -{ - PIIX4_DPRINTF("pciej read %x\n", addr); - return 0; -} - static void pciej_write(void *opaque, uint32_t addr, uint32_t val) { - BusState *bus = opaque; + PIIX4PMState *s = opaque; + PCIDevice *dev = &s->dev; + BusState *bus = qdev_get_parent_bus(&dev->qdev); DeviceState *qdev, *next; int slot = ffs(val) - 1; @@ -548,8 +544,7 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s) register_ioport_read(PCI_UP_BASE, 8, 4, pci_updown_read, s); - register_ioport_write(PCI_EJ_BASE, 4, 4, pciej_write, bus); - register_ioport_read(PCI_EJ_BASE, 4, 4, pciej_read, bus); + register_ioport_write(PCI_EJ_BASE, 4, 4, pciej_write, s); register_ioport_write(PCI_RMV_BASE, 4, 4, pcirmv_write, s); register_ioport_read(PCI_RMV_BASE, 4, 4, pcirmv_read, s);