From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, ddutile@redhat.com, gleb@redhat.com,
mst@redhat.com
Subject: [Qemu-devel] [PATCH 6/6] api_piix4: Remove PCI_RMV_BASE write code
Date: Tue, 06 Mar 2012 17:15:21 -0700 [thread overview]
Message-ID: <20120307001517.3079.65758.stgit@bling.home> (raw)
In-Reply-To: <20120307000340.3079.87515.stgit@bling.home>
Achieves the same result with less code.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/acpi_piix4.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 4640e2e..3db0efd 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -532,11 +532,6 @@ static uint32_t pcirmv_read(void *opaque, uint32_t addr)
return s->pci0_hotplug_enable;
}
-static void pcirmv_write(void *opaque, uint32_t addr, uint32_t val)
-{
- return;
-}
-
extern const char *global_cpu_model;
static int piix4_device_hotplug(DeviceState *qdev, PCIDevice *dev,
@@ -562,7 +557,6 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s)
register_ioport_write(PCI_EJ_BASE, 4, 4, pciej_write, s);
- register_ioport_write(PCI_RMV_BASE, 4, 4, pcirmv_write, s);
register_ioport_read(PCI_RMV_BASE, 4, 4, pcirmv_read, s);
pci_bus_hotplug(bus, piix4_device_hotplug, &s->dev.qdev);
next prev parent reply other threads:[~2012-03-07 0:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 0:13 [Qemu-devel] [PATCH 0/6] PCI hotplug improvements Alex Williamson
2012-03-07 0:13 ` [Qemu-devel] [PATCH 1/6] acpi_piix4: Disallow write to up/down PCI hotplug registers Alex Williamson
2012-03-07 0:14 ` [Qemu-devel] [PATCH 2/6] acpi_piix4: Only allow writes to PCI hotplug eject register Alex Williamson
2012-03-07 0:14 ` [Qemu-devel] [PATCH 3/6] pci: Add notifier for device probing Alex Williamson
2012-03-07 9:19 ` Paolo Bonzini
2012-03-07 20:12 ` Alex Williamson
2012-03-07 0:14 ` [Qemu-devel] [PATCH 4/6] acpi_piix4: Track PCI hotplug status and allow non-ACPI remove path Alex Williamson
2012-03-11 21:57 ` Michael S. Tsirkin
2012-03-07 0:15 ` [Qemu-devel] [PATCH 5/6] acpi_piix4: Use pci_get/set_byte Alex Williamson
2012-03-07 0:15 ` Alex Williamson [this message]
2012-03-07 12:43 ` [Qemu-devel] [PATCH 0/6] PCI hotplug improvements Gleb Natapov
2012-03-07 17:20 ` Alex Williamson
2012-03-07 18:59 ` Gleb Natapov
2012-03-07 19:51 ` Alex Williamson
2012-03-07 21:00 ` Gleb Natapov
2012-03-07 21:44 ` Alex Williamson
2012-03-07 22:17 ` Gleb Natapov
2012-03-07 22:46 ` Alex Williamson
2012-03-08 12:39 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307001517.3079.65758.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=ddutile@redhat.com \
--cc=gleb@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).