qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: jan.kiszka@siemens.com, xen-devel@lists.xensource.com,
	qemu-devel@nongnu.org, anthony@codemonkey.ws, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier
Date: Wed, 7 Mar 2012 14:41:01 -0300	[thread overview]
Message-ID: <20120307144101.0c2b049e@doriath.home> (raw)
In-Reply-To: <1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com>

On Tue, 28 Feb 2012 15:51:32 +0000
Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:

> Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Would be nice to explain why, but I suggested this myself so:

 Acked-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  vl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index 5b2b84c..341775b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3099,6 +3099,7 @@ int main(int argc, char **argv, char **envp)
>                  break;
>              case QEMU_OPTION_incoming:
>                  incoming = optarg;
> +                runstate_set(RUN_STATE_INMIGRATE);
>                  break;
>              case QEMU_OPTION_nodefaults:
>                  default_serial = 0;
> @@ -3596,7 +3597,6 @@ int main(int argc, char **argv, char **envp)
>      }
>  
>      if (incoming) {
> -        runstate_set(RUN_STATE_INMIGRATE);
>          int ret = qemu_start_incoming_migration(incoming);
>          if (ret < 0) {
>              fprintf(stderr, "Migration failed. Exit code %s(%d), exiting.\n",

  parent reply	other threads:[~2012-03-07 17:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 15:50 [Qemu-devel] [PATCH RESEND v5 0/6] save/restore on Xen Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 1/6] cirrus_vga: do not reset videoram Stefano Stabellini
2012-02-28 18:35   ` Anthony PERARD
2012-03-12 12:43   ` Avi Kivity
2012-03-12 13:18     ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 2/6] Introduce "save_devices" Stefano Stabellini
2012-02-28 18:58   ` Anthony PERARD
2012-03-12 18:33   ` Anthony Liguori
2012-03-13 11:51     ` Stefano Stabellini
2012-03-13 19:26       ` Luiz Capitulino
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier Stefano Stabellini
2012-02-28 19:34   ` Anthony PERARD
2012-03-07 17:41   ` Luiz Capitulino [this message]
2012-03-12 12:17     ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 4/6] xen: record physmap changes to xenstore Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 5/6] xen mapcache: check if memory region has moved Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 6/6] xen: do not allocate RAM during INMIGRATE runstate Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120307144101.0c2b049e@doriath.home \
    --to=lcapitulino@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).