From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5Kwh-0002MF-Mb for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:46:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5KwN-0000jL-Fi for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:46:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5KwN-0000il-6s for qemu-devel@nongnu.org; Wed, 07 Mar 2012 12:46:19 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q27HkGdK027411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Mar 2012 12:46:17 -0500 Date: Wed, 7 Mar 2012 14:46:19 -0300 From: Luiz Capitulino Message-ID: <20120307144619.2cb5ff24@doriath.home> In-Reply-To: <1330953208-25147-1-git-send-email-alevy@redhat.com> References: <1330953208-25147-1-git-send-email-alevy@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi-schema: fix typos and explain 'spice' auth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On Mon, 5 Mar 2012 15:13:27 +0200 Alon Levy wrote: > Signed-off-by: Alon Levy Applied both patches to the qmp branch, thanks. > --- > qapi-schema.json | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) > > v1->v2: > - Fixes wrong indentation for second spice channel-id > - split the last part (ObjectPropertyInfo). > > diff --git a/qapi-schema.json b/qapi-schema.json > index 5f293c4..93ee2a4 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -616,11 +616,12 @@ > # @connection-id: SPICE connection id number. All channels with the same id > # belong to the same SPICE session. > # > -# @connection-type: SPICE channel type number. "1" is the main control channel, > -# filter for this one if you want track spice sessions only > +# @connection-type: SPICE channel type number. "1" is the main control > +# channel, filter for this one if you want to track spice > +# sessions only > # > -# @channel-id: SPICE channel ID number. Usually "0", might be different needed > -# when multiple channels of the same type exist, such as multiple > +# @channel-id: SPICE channel ID number. Usually "0", might be different when > +# multiple channels of the same type exist, such as multiple > # display channels in a multihead setup > # > # @tls: true if the channel is encrypted, false otherwise. > @@ -649,8 +650,9 @@ > # @tls-port: #optional The SPICE server's TLS port number. > # > # @auth: #optional the current authentication type used by the server > -# 'none' if no authentication is being used > -# 'spice' (TODO: describe) > +# 'none' if no authentication is being used > +# 'spice' uses SASL or direct TLS authentication, depending on command > +# line options > # > # @channels: a list of @SpiceChannel for each active spice channel > #