From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5YVm-0006Im-31 for qemu-devel@nongnu.org; Thu, 08 Mar 2012 03:16:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5YVj-0000kD-Ol for qemu-devel@nongnu.org; Thu, 08 Mar 2012 03:15:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5YVj-0000k2-GV for qemu-devel@nongnu.org; Thu, 08 Mar 2012 03:15:43 -0500 Date: Thu, 8 Mar 2012 10:15:30 +0200 From: Alon Levy Message-ID: <20120308081530.GE7273@garlic.redhat.com> References: <1330424430-23015-1-git-send-email-kraxel@redhat.com> <1330424430-23015-14-git-send-email-kraxel@redhat.com> <4F585BC3.6040802@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4F585BC3.6040802@cn.fujitsu.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 13/21] libcacard: fix reported ATR length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , Anthony Liguori Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Thu, Mar 08, 2012 at 03:12:03PM +0800, Wen Congyang wrote: > At 02/28/2012 06:20 PM, Gerd Hoffmann Wrote: > > From: Alon Levy > >=20 > > Signed-off-by: Alon Levy > > Signed-off-by: Gerd Hoffmann > > --- > > libcacard/vcardt.h | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h > > index 538bdde..d4d8e2e 100644 > > --- a/libcacard/vcardt.h > > +++ b/libcacard/vcardt.h > > @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul; > > #define MAX_CHANNEL 4 > > =20 > > /* create an ATR with appropriate historical bytes */ > > -#define VCARD_ATR_PREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \ > > - 'V', 'C', 'A', 'R', 'D', '_' > > +#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \ > > + 'V', 'C', 'A', 'R', 'D', '_') > > =20 > > =20 > > typedef enum { >=20 > qemu build faile with this patch: This is fixed by a patch on the list: http://patchwork.ozlabs.org/patch/144276/ Anthony, could you please apply that patch, or should I send a pull reque= st with it? Alon >=20 > CC libcacard/vcard_emul_nss.o > cc1: warnings being treated as errors > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: left-hand operand of comma expression has = no effect > vcard_emul_nss.c:528: error: initializer element is not constant > vcard_emul_nss.c:528: error: (near initialization for =E2=80=98nss_atr[= 0]=E2=80=99) > make[1]: *** [vcard_emul_nss.o] Error 1 > make: *** [subdir-libcacard] Error 2 >=20 > I donot know this patch's purpose, so I donot know how to fix it. I gue= ss this > patch is unnecessary. >=20 > Thanks > Wen Congyang