From: David Gibson <dwg@au1.ibm.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h for uintptr_t
Date: Thu, 8 Mar 2012 21:25:47 +1100 [thread overview]
Message-ID: <20120308102547.GF10735@truffala.fritz.box> (raw)
In-Reply-To: <4F584D5E.304@weilnetz.de>
On Thu, Mar 08, 2012 at 07:10:38AM +0100, Stefan Weil wrote:
> Am 08.03.2012 02:09, schrieb David Gibson:
> >cache-utils.h uses the C99 standard uintptr_t type. However, that type
> >comes from stdint.h which is not #included before cache-utils.h in all
> >configurations. This patch adds the necessary include to fix this.
> >
> >Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> >---
> > cache-utils.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/cache-utils.h b/cache-utils.h
> >index 04a6e2e..b0f1786 100644
> >--- a/cache-utils.h
> >+++ b/cache-utils.h
> >@@ -1,6 +1,8 @@
> > #ifndef QEMU_CACHE_UTILS_H
> > #define QEMU_CACHE_UTILS_H
> >
> >+#include<stdint.h>
> >+
> > #if defined(_ARCH_PPC)
> > struct qemu_cache_conf {
> > unsigned long dcache_bsize;
>
> The include statement is only needed for _ARCH_PPC.
>
> See http://patchwork.ozlabs.org/patch/144763/ which
> fixes the same issue.
Ok, cool, didn't spot that one.
> Anthony, Blue, could someone please commit my patch?
>
> Regards,
>
> Stefan W.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-03-08 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 1:09 [Qemu-devel] [PATCH 1/2] .gitignore update David Gibson
2012-03-08 1:09 ` [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h for uintptr_t David Gibson
2012-03-08 6:10 ` Stefan Weil
2012-03-08 10:25 ` David Gibson [this message]
2012-03-15 8:21 ` [Qemu-devel] [PATCH 1/2] .gitignore update Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308102547.GF10735@truffala.fritz.box \
--to=dwg@au1.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).