From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1S5dfN-00006G-Lv
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 08:46:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1S5dfF-0002Lz-J1
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 08:46:01 -0500
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:58522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1S5dfF-0002L6-1U
	for qemu-devel@nongnu.org; Thu, 08 Mar 2012 08:45:53 -0500
Received: from /spool/local
	by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <dwg@au1.ibm.com>;
	Thu, 8 Mar 2012 13:40:03 +1000
Date: Thu, 8 Mar 2012 21:25:47 +1100
From: David Gibson <dwg@au1.ibm.com>
Message-ID: <20120308102547.GF10735@truffala.fritz.box>
References: <1331168981-13139-1-git-send-email-david@gibson.dropbear.id.au>
	<1331168981-13139-2-git-send-email-david@gibson.dropbear.id.au>
	<4F584D5E.304@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F584D5E.304@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h for
 uintptr_t
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Thu, Mar 08, 2012 at 07:10:38AM +0100, Stefan Weil wrote:
> Am 08.03.2012 02:09, schrieb David Gibson:
> >cache-utils.h uses the C99 standard uintptr_t type.  However, that type
> >comes from stdint.h which is not #included before cache-utils.h in all
> >configurations.  This patch adds the necessary include to fix this.
> >
> >Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> >---
> >  cache-utils.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/cache-utils.h b/cache-utils.h
> >index 04a6e2e..b0f1786 100644
> >--- a/cache-utils.h
> >+++ b/cache-utils.h
> >@@ -1,6 +1,8 @@
> >  #ifndef QEMU_CACHE_UTILS_H
> >  #define QEMU_CACHE_UTILS_H
> >
> >+#include<stdint.h>
> >+
> >  #if defined(_ARCH_PPC)
> >  struct qemu_cache_conf {
> >      unsigned long dcache_bsize;
> 
> The include statement is only needed for _ARCH_PPC.
> 
> See http://patchwork.ozlabs.org/patch/144763/ which
> fixes the same issue.

Ok, cool, didn't spot that one.

> Anthony, Blue, could someone please commit my patch?
> 
> Regards,
> 
> Stefan W.
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson