[Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

[Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

[Alain Ribière]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hello,

I'm reacting a bit later but I have a trouble with an old DOS OS from Digital Research called Concurrent DOS.
It worked fine till Qemu v0.11.1.
I tried it with a lot of versions from 0.12.0 to 1.0.1 and it boot correctly. But after a key pressed, I can't use the keyboard any more. The system is not freezed (there is a clock in the bottom side of the screen which is running) but I can't use the keyboard any more.
It worked also with 0.12.0-rc1 and the PC-BIOS. It seems that with Seabios it doesn't work any more but PC-BIOS is no longer supported by QEMU (from v0.12.0).

Do you know what can I do ?

Thanks,

Alain

[-- Attachment #2: Type: text/html, Size: 915 bytes --]

Re: [Qemu-devel] Regression: more 0.12 regression (SeaBIOS related?)

[Kevin O'Connor]

On Tue, Mar 06, 2012 at 09:00:55AM -0800, Alain Ribière wrote:
> Hello,
> 
> I'm reacting a bit later but I have a trouble with an old DOS OS from Digital Research called Concurrent DOS.
> It worked fine till Qemu v0.11.1.
> I tried it with a lot of versions from 0.12.0 to 1.0.1 and it boot correctly. But after a key pressed, I can't use the keyboard any more. The system is not freezed (there is a clock in the bottom side of the screen which is running) but I can't use the keyboard any more.
> It worked also with 0.12.0-rc1 and the PC-BIOS. It seems that with Seabios it doesn't work any more but PC-BIOS is no longer supported by QEMU (from v0.12.0).
> 
> Do you know what can I do ?

You can help debug the issue so it can be fixed in SeaBIOS.  Start
with producing a log from SeaBIOS by adding (on a recent qemu) the
following to the command-line:

-chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios

Also, if there is an image available for download, other developers
can take a look at it as well.

-Kevin

[Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Alain Ribière]

[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]

I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
qemu-system-i386 -L git/bios -fda disk.img -no-fd-bootchk -boot a -m 16


Here is the log :
https://docs.google.com/open?id=0B7mz0vq6Rpb7UE1ibjJDcEhTRWlNV050QnMyMWwtZw

Here is the floppy disk image I used :

https://docs.google.com/open?id=0B7mz0vq6Rpb7bHpYaEt2SnVUUi1KaWE3a3lBQUJpQQ


The floppy disk is simply a C-DOS 720 Ko floppy created by "format a: /s". So it's quite empty.

Qemu doesn't crash or freeze. But I can just type a single character and the nothing else. But the system is still running (there is a clock at the bottom right of the screen).


Thanks,

Alain



________________________________
 De : Kevin O'Connor <kevin@koconnor.net>
À : Alain Ribière <alain_ribiere@yahoo.com> 
Cc : "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>; seabios@seabios.org 
Envoyé le : Mercredi 7 mars 2012 14h38
Objet : Re: [Qemu-devel]  Regression: more 0.12 regression (SeaBIOS related?)
 
On Tue, Mar 06, 2012 at 09:00:55AM -0800, Alain Ribière wrote:
> Hello,
> 
> I'm reacting a bit later but I have a trouble with an old DOS OS from Digital Research called Concurrent DOS.
> It worked fine till Qemu v0.11.1.
> I tried it with a lot of versions from 0.12.0 to 1.0.1 and it boot correctly. But after a key pressed, I can't use the keyboard any more. The system is not freezed (there is a clock in the bottom side of the screen which is running) but I can't use the keyboard any more.
> It worked also with 0.12.0-rc1 and the PC-BIOS. It seems that with Seabios it doesn't work any more but PC-BIOS is no longer supported by QEMU (from v0.12.0).
> 
> Do you know what can I do ?

You can help debug the issue so it can be fixed in SeaBIOS.  Start
with producing a log from SeaBIOS by adding (on a recent qemu) the
following to the command-line:

-chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios

Also, if there is an image available for download, other developers
can take a look at it as well.

-Kevin

[-- Attachment #2: Type: text/html, Size: 3176 bytes --]

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Luiz Capitulino]

On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
Alain Ribière <alain_ribiere@yahoo.com> wrote:

> I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :

What's the git HEAD?

Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
during bootup. After debugging a bit, I found out that latest seabios fixes the
problem but couldn't identify the actual commit.

The git HEAD of my seabios repo is c5c488f46b.

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Kevin O'Connor]

On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> Alain Ribière <alain_ribiere@yahoo.com> wrote:
> 
> > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> 
> What's the git HEAD?
> 
> Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> during bootup. After debugging a bit, I found out that latest seabios fixes the
> problem but couldn't identify the actual commit.
> 
> The git HEAD of my seabios repo is c5c488f46b.

Daniel reported a similar error.  I haven't had a chance to look at it
yet.

-Kevin

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Daniel P. Berrange]

On Thu, Mar 08, 2012 at 09:01:12AM -0500, Kevin O'Connor wrote:
> On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> > On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> > Alain Ribière <alain_ribiere@yahoo.com> wrote:
> > 
> > > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > 
> > What's the git HEAD?
> > 
> > Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> > during bootup. After debugging a bit, I found out that latest seabios fixes the
> > problem but couldn't identify the actual commit.
> > 
> > The git HEAD of my seabios repo is c5c488f46b.
> 
> Daniel reported a similar error.  I haven't had a chance to look at it
> yet.

This was the issue where QEMU's binary build of Seabios was broken.
Rebuilding the exact same Seabios changeset from source works fine.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Luiz Capitulino]

On Thu, 8 Mar 2012 14:09:05 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Mar 08, 2012 at 09:01:12AM -0500, Kevin O'Connor wrote:
> > On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> > > On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> > > Alain Ribière <alain_ribiere@yahoo.com> wrote:
> > > 
> > > > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > > 
> > > What's the git HEAD?
> > > 
> > > Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> > > during bootup. After debugging a bit, I found out that latest seabios fixes the
> > > problem but couldn't identify the actual commit.
> > > 
> > > The git HEAD of my seabios repo is c5c488f46b.
> > 
> > Daniel reported a similar error.  I haven't had a chance to look at it
> > yet.
> 
> This was the issue where QEMU's binary build of Seabios was broken.
> Rebuilding the exact same Seabios changeset from source works fine.

Are you running qemu 1.0 or latest from git?

qemu 1.0 has seabios from commit 8e301472e324, I don't get the problem with
this one. But latest qemu from git has seabios 1.6.3.1, it's with that
version that I get my problem.

Using latest seabios makes it go away, didn't try re-building 1.6.3.1 though.

Re: [Qemu-devel] [SeaBIOS] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Peter Stuge]

Luiz Capitulino wrote:
> Using latest seabios makes it go away, didn't try re-building
> 1.6.3.1 though.

Try it, if your toolchain is not broken it should work.


//Peter

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Daniel P. Berrange]

On Thu, Mar 08, 2012 at 11:28:25AM -0300, Luiz Capitulino wrote:
> On Thu, 8 Mar 2012 14:09:05 +0000
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
> 
> > On Thu, Mar 08, 2012 at 09:01:12AM -0500, Kevin O'Connor wrote:
> > > On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> > > > On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> > > > Alain Ribière <alain_ribiere@yahoo.com> wrote:
> > > > 
> > > > > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > > > 
> > > > What's the git HEAD?
> > > > 
> > > > Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> > > > during bootup. After debugging a bit, I found out that latest seabios fixes the
> > > > problem but couldn't identify the actual commit.
> > > > 
> > > > The git HEAD of my seabios repo is c5c488f46b.
> > > 
> > > Daniel reported a similar error.  I haven't had a chance to look at it
> > > yet.
> > 
> > This was the issue where QEMU's binary build of Seabios was broken.
> > Rebuilding the exact same Seabios changeset from source works fine.
> 
> Are you running qemu 1.0 or latest from git?

Using GIT

> qemu 1.0 has seabios from commit 8e301472e324, I don't get the problem with
> this one. But latest qemu from git has seabios 1.6.3.1, it's with that
> version that I get my problem.

That's the same I found - simply rebuilding 1.6.3.1 gives a binary that
works fine.

> Using latest seabios makes it go away, didn't try re-building 1.6.3.1 though.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Luiz Capitulino]

On Thu, 8 Mar 2012 14:37:47 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Mar 08, 2012 at 11:28:25AM -0300, Luiz Capitulino wrote:
> > On Thu, 8 Mar 2012 14:09:05 +0000
> > "Daniel P. Berrange" <berrange@redhat.com> wrote:
> > 
> > > On Thu, Mar 08, 2012 at 09:01:12AM -0500, Kevin O'Connor wrote:
> > > > On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> > > > > On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> > > > > Alain Ribière <alain_ribiere@yahoo.com> wrote:
> > > > > 
> > > > > > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > > > > 
> > > > > What's the git HEAD?
> > > > > 
> > > > > Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> > > > > during bootup. After debugging a bit, I found out that latest seabios fixes the
> > > > > problem but couldn't identify the actual commit.
> > > > > 
> > > > > The git HEAD of my seabios repo is c5c488f46b.
> > > > 
> > > > Daniel reported a similar error.  I haven't had a chance to look at it
> > > > yet.
> > > 
> > > This was the issue where QEMU's binary build of Seabios was broken.
> > > Rebuilding the exact same Seabios changeset from source works fine.
> > 
> > Are you running qemu 1.0 or latest from git?
> 
> Using GIT
> 
> > qemu 1.0 has seabios from commit 8e301472e324, I don't get the problem with
> > this one. But latest qemu from git has seabios 1.6.3.1, it's with that
> > version that I get my problem.
> 
> That's the same I found - simply rebuilding 1.6.3.1 gives a binary that
> works fine.

Yeah, just tried it, worked.

I think we're thinking in updating our seabios version soon?

[Qemu-devel] Re : Re : Regression: more 0.12 regression (SeaBIOS related?)

[Alain Ribière]

[-- Attachment #1: Type: text/plain, Size: 2618 bytes --]

I still have the problem with :
seabios git : c5c488f46b (it shoes a version pre-1.6.4-20120308_165857)

qemu git : 1c8a881daa (v1.0)
I also tried with latest qemu from git : e326050 (snapshot from the git.qemu.org)
And it doesn't work for me.
Have you tried my disk image ?

It doesn't crash. I can just type a character, which prints on the screen, and then nothing.

Maybe I made something wrong...


Thanks,

Alain



________________________________
 De : Luiz Capitulino <lcapitulino@redhat.com>
À : Daniel P. Berrange <berrange@redhat.com> 
Cc : Kevin O'Connor <kevin@koconnor.net>; Alain Ribière <alain_ribiere@yahoo.com>; "seabios@seabios.org" <seabios@seabios.org>; "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>; peter@stuge.se; jan.kiszka@siemens.com 
Envoyé le : Jeudi 8 mars 2012 15h45
Objet : Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)
 
On Thu, 8 Mar 2012 14:37:47 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Mar 08, 2012 at 11:28:25AM -0300, Luiz Capitulino wrote:
> > On Thu, 8 Mar 2012 14:09:05 +0000
> > "Daniel P. Berrange" <berrange@redhat.com> wrote:
> > 
> > > On Thu, Mar 08, 2012 at 09:01:12AM -0500, Kevin O'Connor wrote:
> > > > On Thu, Mar 08, 2012 at 10:56:01AM -0300, Luiz Capitulino wrote:
> > > > > On Wed, 7 Mar 2012 06:31:31 -0800 (PST)
> > > > > Alain Ribière <alain_ribiere@yahoo.com> wrote:
> > > > > 
> > > > > > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > > > > 
> > > > > What's the git HEAD?
> > > > > 
> > > > > Coincidentally, I was playing with MS-DOS 6.22 yesterday and hit an issue right
> > > > > during bootup. After debugging a bit, I found out that latest seabios fixes the
> > > > > problem but couldn't identify the actual commit.
> > > > > 
> > > > > The git HEAD of my seabios repo is c5c488f46b.
> > > > 
> > > > Daniel reported a similar error.  I haven't had a chance to look at it
> > > > yet.
> > > 
> > > This was the issue where QEMU's binary build of Seabios was broken.
> > > Rebuilding the exact same Seabios changeset from source works fine.
> > 
> > Are you running qemu 1.0 or latest from git?
> 
> Using GIT
> 
> > qemu 1.0 has seabios from commit 8e301472e324, I don't get the problem with
> > this one. But latest qemu from git has seabios 1.6.3.1, it's with that
> > version that I get my problem.
> 
> That's the same I found - simply rebuilding 1.6.3.1 gives a binary that
> works fine.

Yeah, just tried it, worked.

I think we're thinking in updating our seabios version soon?

[-- Attachment #2: Type: text/html, Size: 4338 bytes --]

Re: [Qemu-devel] Re : Regression: more 0.12 regression (SeaBIOS related?)

[Kevin O'Connor]

On Wed, Mar 07, 2012 at 06:31:31AM -0800, Alain Ribière wrote:
> I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> qemu-system-i386 -L git/bios -fda disk.img -no-fd-bootchk -boot a -m 16
> 
> Here is the log :
> https://docs.google.com/open?id=0B7mz0vq6Rpb7UE1ibjJDcEhTRWlNV050QnMyMWwtZw
> 
> Here is the floppy disk image I used :
> 
> https://docs.google.com/open?id=0B7mz0vq6Rpb7bHpYaEt2SnVUUi1KaWE3a3lBQUJpQQ
> 
> 
> The floppy disk is simply a C-DOS 720 Ko floppy created by "format
> a: /s". So it's quite empty.
> 
> Qemu doesn't crash or freeze. But I can just type a single character
> and the nothing else. But the system is still running (there is a
> clock at the bottom right of the screen).

I tracked this down.  Looks like the image takes over the PS2 irq and
keyboard handling, but then occasionally calls into the BIOS.  When it
does call the BIOS irq handler (manually), it expects the irq handler
to enable the keyboard.  Weird.

Anyway, the patch below fixes it for me.

-Kevin


>From 90ce89f8953da0e89c311aa34116b59aac1c6c5e Mon Sep 17 00:00:00 2001
From: Kevin O'Connor <kevin@koconnor.net>
Date: Sun, 11 Mar 2012 20:45:56 -0400
Subject: [PATCH] ps2: Enable keyboard at end of PS2 port irq.
To: seabios@seabios.org

Looks like some old programs expect the keyboard irq to enable the
keyboard port at the end of the irq.  This behavior was seen on an
image of "Concurrent DOS".

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
---
 src/ps2port.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/ps2port.c b/src/ps2port.c
index 1f04299..4b27b7a 100644
--- a/src/ps2port.c
+++ b/src/ps2port.c
@@ -404,6 +404,9 @@ handle_09(void)
 
     process_key(v);
 
+    // Some old programs expect ISR to turn keyboard back on.
+    i8042_command(I8042_CMD_KBD_ENABLE, NULL);
+
 done:
     eoi_pic1();
 }
-- 
1.7.6.5

[Qemu-devel] Re : Re : Regression: more 0.12 regression (SeaBIOS related?)

[Alain Ribière]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

>On Wed, Mar 07, 2012 at 06:31:31AM -0800, Alain Ribière wrote:

> > I ran qemu 1.0.1 and the latest SeaBIOS (from the git) with the following options :
> > qemu-system-i386 -L git/bios -fda disk.img -no-fd-bootchk -boot a -m 16
> > 
> > Here is the log :
> > https://docs.google.com/open?id=0B7mz0vq6Rpb7UE1ibjJDcEhTRWlNV050QnMyMWwtZw
> > 
> > Here is the floppy disk image I used :
> > 
> > https://docs.google.com/open?id=0B7mz0vq6Rpb7bHpYaEt2SnVUUi1KaWE3a3lBQUJpQQ
> > 
> > 
> > The floppy disk is simply a C-DOS 720 Ko floppy created by "format
> > a: /s". So it's quite empty.
> > 
> > Qemu doesn't crash or freeze. But I can just type a single character
> > and the nothing else. But the system is still running (there is a
> > clock at the bottom right of the screen).
> 
> I tracked this down.  Looks like the image takes over the PS2 irq and
> keyboard handling, but then occasionally calls into the BIOS.  When it
> does call the BIOS irq handler (manually), it expects the irq handler
> to enable the keyboard.  Weird.
> 
> Anyway, the patch below fixes it for me.
> 
> -Kevin

Great ! It works for me too.

Thanks a lot,

Alain

[-- Attachment #2: Type: text/html, Size: 1772 bytes --]