* [Qemu-devel] [patch] make trace_thread_create() use its function arg
@ 2012-03-08 6:20 Jun Koi
2012-03-08 11:59 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Jun Koi @ 2012-03-08 6:20 UTC (permalink / raw)
To: qemu-devel
this patch makes trace_thread_create() to use its function arg to
initialize thread.
the other choice is to make this a function to use void arg, but i
prefer this way.
Signed-off-by: Jun Koi <junkoi2004@gmail.com>
diff --git a/trace/simple.c b/trace/simple.c
index bbc9930..33ae486 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -363,7 +363,7 @@ static GThread *trace_thread_create(GThreadFunc fn)
sigfillset(&set);
pthread_sigmask(SIG_SETMASK, &set, &oldset);
#endif
- thread = g_thread_create(writeout_thread, NULL, FALSE, NULL);
+ thread = g_thread_create(fn, NULL, FALSE, NULL);
#ifndef _WIN32
pthread_sigmask(SIG_SETMASK, &oldset, NULL);
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [patch] make trace_thread_create() use its function arg
2012-03-08 6:20 [Qemu-devel] [patch] make trace_thread_create() use its function arg Jun Koi
@ 2012-03-08 11:59 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-03-08 11:59 UTC (permalink / raw)
To: Jun Koi; +Cc: qemu-devel
On Thu, Mar 08, 2012 at 02:20:37PM +0800, Jun Koi wrote:
> this patch makes trace_thread_create() to use its function arg to
> initialize thread.
> the other choice is to make this a function to use void arg, but i
> prefer this way.
>
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
>
Thanks, applied to the tracing patches tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-08 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 6:20 [Qemu-devel] [patch] make trace_thread_create() use its function arg Jun Koi
2012-03-08 11:59 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).