From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64a4-0001us-EU for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S64a2-00029H-Dh for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:30:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S64a2-000298-5W for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:30:18 -0500 Date: Fri, 9 Mar 2012 15:30:19 -0300 From: Luiz Capitulino Message-ID: <20120309153019.32846104@doriath.home> In-Reply-To: <4F5A4A08.8030805@siemens.com> References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "pbonzini@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "quintela@redhat.com" On Fri, 09 Mar 2012 19:20:56 +0100 Jan Kiszka wrote: > On 2012-03-09 19:13, Luiz Capitulino wrote: > > The Monitor object is passed back and forth within the migration/savevm > > code so that it can print errors and progress to the user. > > > > However, that approach assumes a HMP monitor, being completely invalid > > in QMP. > > > > This commit drops almost every single usage of the Monitor object, all > > monitor_printf() calls have been converted into DPRINTF() ones. > > I guess for most printfs, this is OK. But do you provide an alternative > for the block migration progress output? I did not find anything on > first glance. That is not a debugging feature. Can't the info migrate command be used for that?