From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34895)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S64hD-0006yG-AF
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:37:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S64hB-0003Wu-K4
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:37:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5445)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S64hB-0003Wk-CI
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 13:37:41 -0500
Date: Fri, 9 Mar 2012 15:37:42 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120309153742.5fcba611@doriath.home>
In-Reply-To: <4F5A4D74.4090702@us.ibm.com>
References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com>
	<1331316786-7752-5-git-send-email-lcapitulino@redhat.com>
	<4F5A4B6D.8080606@redhat.com> <4F5A4D74.4090702@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Convert migrate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: pbonzini@redhat.com, quintela@redhat.com, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org, jan.kiszka@siemens.com

On Fri, 09 Mar 2012 12:35:32 -0600
Anthony Liguori <aliguori@us.ibm.com> wrote:

> >> +##
> >> +# @migrate
> >> +#
> >> +# Migrates the current running guest to another Virtual Machine.
> >> +#
> >> +# @uri: the Uniform Resource Identifier of the destination VM
> >> +#
> >> +# @blk: #optional do block migration (full disk copy)
> >> +#
> >> +# @inc: #optional incremental disk copy migration
> >> +#
> >> +# @detach: this argument exists only for compatibility reasons and should not
> >> +#          be used.
> >
> > Libvirt is currently using it, but it appears that libvirt always sets
> > it to true.  Does this mean the argument is ignored no matter whether
> > you pass true or false?
> 
> Yes, and we should specify that.  The argument is ignored by QEMU.

Will do for v3.