From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65ni-0007Tv-Lv for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:48:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S65nO-0007c0-7Q for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:48:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S65nO-0007bR-0O for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:48:10 -0500 Date: Fri, 9 Mar 2012 16:48:10 -0300 From: Luiz Capitulino Message-ID: <20120309164810.28dfb64b@doriath.home> In-Reply-To: <4F5A562B.8000109@us.ibm.com> References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> <20120309153019.32846104@doriath.home> <4F5A5463.9010803@siemens.com> <4F5A562B.8000109@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , "pbonzini@redhat.com" , "qemu-devel@nongnu.org" , "quintela@redhat.com" On Fri, 09 Mar 2012 13:12:43 -0600 Anthony Liguori wrote: > On 03/09/2012 01:05 PM, Jan Kiszka wrote: > > On 2012-03-09 19:30, Luiz Capitulino wrote: > >> On Fri, 09 Mar 2012 19:20:56 +0100 > >> Jan Kiszka wrote: > >> > >>> On 2012-03-09 19:13, Luiz Capitulino wrote: > >>>> The Monitor object is passed back and forth within the migration/savevm > >>>> code so that it can print errors and progress to the user. > >>>> > >>>> However, that approach assumes a HMP monitor, being completely invalid > >>>> in QMP. > >>>> > >>>> This commit drops almost every single usage of the Monitor object, all > >>>> monitor_printf() calls have been converted into DPRINTF() ones. > >>> > >>> I guess for most printfs, this is OK. But do you provide an alternative > >>> for the block migration progress output? I did not find anything on > >>> first glance. That is not a debugging feature. > >> > >> Can't the info migrate command be used for that? > > > > This was introduced for synchronous migration, as usability improvement. > > Synchronous migration doesn't exist in QMP. > > It's certainly possible to make the synchronous monitor command spit out status > as it already uses a polling loop to determine when migration completes. As HMP now uses QMP as a real client, we'd have to make that information available for all QMP users. Best place is probably query-migrate. Don't you prefer to drop the whole thing instead? :-)