From: David Gibson <david@gibson.dropbear.id.au>
To: Kevin Wolf <kwolf@redhat.com>
Cc: rth@twiddle.net, eduard.munteanu@linux360.ro, mst@redhat.com,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions
Date: Sat, 10 Mar 2012 16:30:25 +1100 [thread overview]
Message-ID: <20120310053025.GC24916@truffala.fritz.box> (raw)
In-Reply-To: <4F59D1E4.7030807@redhat.com>
On Fri, Mar 09, 2012 at 10:48:20AM +0100, Kevin Wolf wrote:
> Am 09.03.2012 06:01, schrieb David Gibson:
> > The AHCI device can provide both PCI and SysBus AHCI device
> > emulations. For this reason, it wasn't previously converted to use
> > the pci_dma_*() helper functions. Now that we have universal DMA
> > helper functions, this converts AHCI to use them.
> >
> > The DMAContext is obtained from pci_dma_context() in the PCI case and
> > set to NULL in the SysBus case (i.e. we assume for now that a SysBus
> > AHCI has no IOMMU translation).
> >
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> > hw/ide/ahci.c | 7 ++++---
> > hw/ide/ahci.h | 3 ++-
> > hw/ide/ich.c | 2 +-
> > 3 files changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> > index 6a218b5..3d31179 100644
> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -668,7 +668,7 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist)
> > AHCI_SG *tbl = (AHCI_SG *)prdt;
> >
> > /* FIXME: pass the correct DMAContext */
> > - qemu_sglist_init(sglist, sglist_alloc_hint, NULL);
> > + qemu_sglist_init(sglist, sglist_alloc_hint, ad->hba->dma);
>
> Does the FIXME still apply after this change?
Ah, no, I'll fix that in the next version. I've also spotted there
are still a bunch of cpu_physical_memory_*() calls in there that I
either missed, or which have been added since I did the conversion.
I'll tackle that next week.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-03-10 5:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 5:01 [Qemu-devel] [0/13] Implement support for guest visible IOMMUs David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io David Gibson
2012-03-09 9:34 ` Kevin Wolf
2012-03-09 10:01 ` Paolo Bonzini
2012-03-13 5:53 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 02/13] Better support for dma_addr_t variables David Gibson
2012-03-09 10:00 ` Paolo Bonzini
2012-03-09 5:01 ` [Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 04/13] Implement cpu_physical_memory_zero() David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions David Gibson
2012-03-09 10:06 ` Paolo Bonzini
2012-03-09 11:19 ` David Gibson
2012-03-09 11:55 ` Paolo Bonzini
2012-03-09 5:01 ` [Qemu-devel] [PATCH 06/13] usb-ohci: Use " David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers David Gibson
2012-03-09 9:43 ` Kevin Wolf
2012-03-13 10:42 ` David Gibson
2012-03-13 11:55 ` Kevin Wolf
2012-03-09 10:11 ` Paolo Bonzini
2012-03-13 6:37 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions David Gibson
2012-03-09 9:48 ` Kevin Wolf
2012-03-10 5:30 ` David Gibson [this message]
2012-03-09 5:01 ` [Qemu-devel] [PATCH 09/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 10/13] iommu: Introduce IOMMU emulation infrastructure David Gibson
2012-03-09 10:23 ` Paolo Bonzini
2012-03-13 5:07 ` David Gibson
2012-03-13 13:56 ` Alexander Graf
2012-03-13 14:04 ` David Gibson
2012-03-13 14:37 ` Alexander Graf
2012-03-14 9:05 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 11/13] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 12/13] iommu: Allow PCI to use " David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 13/13] pseries: Implement IOMMU and DMA for PAPR PCI devices David Gibson
2012-03-09 10:23 ` Paolo Bonzini
2012-03-09 10:58 ` David Gibson
2012-03-11 2:02 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 2:14 [Qemu-devel] [0/13] RFC: Guest visible IOMMU David Gibson
2012-03-22 2:14 ` [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions David Gibson
2012-03-01 5:35 [Qemu-devel] [0/13] RFC: Support for guest-visible IOMMUs David Gibson
2012-03-01 5:36 ` [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310053025.GC24916@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=eduard.munteanu@linux360.ro \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).