From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7AjQ-0000q8-Hl for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:16:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7AjO-00063z-UJ for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:16:32 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:58076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7AjO-000631-El for qemu-devel@nongnu.org; Mon, 12 Mar 2012 15:16:30 -0400 Received: by wibhr17 with SMTP id hr17so3844678wib.10 for ; Mon, 12 Mar 2012 12:16:28 -0700 (PDT) Date: Mon, 12 Mar 2012 18:18:13 +0000 From: Stefan Hajnoczi Message-ID: <20120312181813.GA21109@stefanha-thinkpad.localdomain> References: <1331112179-12726-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1331112179-12726-3-git-send-email-wdongxu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331112179-12726-3-git-send-email-wdongxu@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 3/4 v2 RESEND] block: add dirty flag status to qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Wed, Mar 07, 2012 at 05:22:58PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > Some block drivers can verify their image files are clean or not. So we can show > it while using "qemu-img info. > > Signed-off-by: Dong Xu Wang > --- > block.c | 14 ++++++++++++++ > block.h | 2 ++ > block_int.h | 1 + > qemu-img.c | 3 +++ > 4 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > index 947607b..17e9ba8 100644 > --- a/block.c > +++ b/block.c > @@ -193,6 +193,20 @@ static void bdrv_io_limits_intercept(BlockDriverState *bs, > qemu_co_queue_next(&bs->throttled_reqs); > } > > +/* check if the image was cleanly shut down */ > +bool bdrv_not_cleanly_down(BlockDriverState *bs) The name is a little cryptic to me and I suggest avoiding 'not' in function names because it easily leads to double-negatives (!not_foo()). How about: bool bdrv_was_shutdown_cleanly() if (!bdrv_was_shutdown_cleanly(bs)) { printf(...); } This patch and the QED patch look fine otherwise. Stefan