From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7Ch5-0001rI-PV
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:22:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7Ch4-0002S0-0E
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:22:15 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:43985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7Ch3-0002Rn-Ps
	for qemu-devel@nongnu.org; Mon, 12 Mar 2012 17:22:13 -0400
Received: by ggnj2 with SMTP id j2so3624464ggn.4
	for <qemu-devel@nongnu.org>; Mon, 12 Mar 2012 14:22:12 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Mon, 12 Mar 2012 16:22:06 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120312212206.GA19058@illuin>
References: <1331557893-30806-1-git-send-email-marcandre.lureau@redhat.com>
	<4F5E4628.8050706@codemonkey.ws>
	<CAJ+F1C+_X4_G_TF2g3YCU7iFQZDHH250HNg=wOoQ4_8s78HVGQ@mail.gmail.com>
	<4F5E470A.5040909@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4F5E470A.5040909@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG
 format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>

On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote:
> On 03/12/2012 01:56 PM, Marc-André Lureau wrote:
> >On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori<anthony@codemonkey.ws>  wrote:
> >>Why not just return the screendump through QMP?
> >
> >in base64, base85?
> 
> I think Jan had patches for base64 blobs but I think it got tangled
> up in VMState related controversy.

Few months back, was planning on using them for qemu-ga. Looks like
they're not in yet, but FWIW qemu-ga has been using g_base64_encode() since
initial commit. I think Jan had some reservations about g_base64_decode()'s
error-handling, but that shouldn't be an issue in this particular case.

I agree on the QMP approach sounding a whole lot cleaner, especially
given that Juan recently did a some cleanups to remove non-migration
QEMUFile users:

3a230256e8418f5cc9761f36feb6952d7ca38d73

> 
> Jan, am I correct?
> 
> Regards,
> 
> Anthony Liguori
> 
>