From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7O9E-00038P-V8 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7O98-0007E8-N1 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:36:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7O98-0007E2-Et for qemu-devel@nongnu.org; Tue, 13 Mar 2012 05:35:58 -0400 Date: Tue, 13 Mar 2012 11:35:51 +0200 From: Alon Levy Message-ID: <20120313093551.GF27659@garlic.redhat.com> References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-2-git-send-email-alevy@redhat.com> <4F5DCE07.5040407@redhat.com> <20120312114311.GH6256@garlic> <20120312155002.GV6256@garlic> <4F5EEC49.2080200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F5EEC49.2080200@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Tue, Mar 13, 2012 at 07:42:17AM +0100, Gerd Hoffmann wrote: > On 03/12/12 16:50, Alon Levy wrote: > > On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote: > >> On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote: > >>> On 03/11/12 20:26, Alon Levy wrote: > >>>> dprint is still used for qxl_init_common one time prints. > >>> > >>> I think we shouldn't simply convert the dprintf's into trace-points. > >>> > >>> We should look at each dprintf and check whenever it makes sense at all, > >>> whenever it makes sense at that place before converting it over to a > >>> tracepoint. > > > > I'll also add qxl_spice_* trace points for the next patch. Does that > > sound excessive? you could just trace the qxl_io_write to get the io > > itself, or trace just qxl_spice_* to get the qxl<->spice interface, or > > both (qxl_*). > > Makes sense to place trace points systematically like that. > What about having the frequent (read: too frequent to use stderr to dump them since they clutter the screen, unless you 'stop' before each monitor command) have a postfix "_freq"? This is a stopgap, but helpful one, you can then do: trace-event qxl* on trace-event qxl*freq off Instead of remembering / having conveniently ready a longer list: trace-event qxl* on trace-event qxl_interface_get_command_enter off trace-event qxl_interface_release_resource off trace-event qxl_interface_get_command_ret off trace-event qxl_push_free_res off > cheers, > Gerd > >