Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events

[Alon Levy <alevy@redhat.com>]

On Tue, Mar 13, 2012 at 10:47:54AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > What about having the frequent (read: too frequent to use stderr to dump
> > them since they clutter the screen, unless you 'stop' before each
> > monitor command) have a postfix "_freq"? This is a stopgap, but helpful
> > one, you can then do:
> > trace-event qxl* on
> > trace-event qxl*freq off
> > 
> > Instead of remembering / having conveniently ready a longer list:
> > trace-event qxl* on
> > trace-event qxl_interface_get_command_enter off
> > trace-event qxl_interface_release_resource off
> > trace-event qxl_interface_get_command_ret off
> > trace-event qxl_push_free_res off
> 
> Hmm, I'd suggest to just try find better names.  These all are about
> ring management (well, free_res is a bit special, but still ...), so maybe:
> 
> qxl_ring_{command,cursor}_check  (check whenever stuff is in there)
> qxl_ring_{command,cursor}_get    (take item out of the ring)
> qxl_ring_res_put                 (stuff item into the ring)
> 
> Then you can match them likewise easy with "qxl_ring_*", but you have
> descriptive names without the IMHO ugly _freq suffix.

Sounds good.

> 
> cheers,
>   Gerd
> 
>