From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7OoP-00076w-HR for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:18:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7Oo1-0007b6-QV for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:18:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Oo1-0007ak-IV for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:18:13 -0400 Date: Tue, 13 Mar 2012 12:18:05 +0200 From: Alon Levy Message-ID: <20120313101805.GH27659@garlic.redhat.com> References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-2-git-send-email-alevy@redhat.com> <4F5DCE07.5040407@redhat.com> <20120312114311.GH6256@garlic> <20120312155002.GV6256@garlic> <4F5EEC49.2080200@redhat.com> <20120313093551.GF27659@garlic.redhat.com> <4F5F17CA.4030304@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F5F17CA.4030304@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Tue, Mar 13, 2012 at 10:47:54AM +0100, Gerd Hoffmann wrote: > Hi, > > > What about having the frequent (read: too frequent to use stderr to dump > > them since they clutter the screen, unless you 'stop' before each > > monitor command) have a postfix "_freq"? This is a stopgap, but helpful > > one, you can then do: > > trace-event qxl* on > > trace-event qxl*freq off > > > > Instead of remembering / having conveniently ready a longer list: > > trace-event qxl* on > > trace-event qxl_interface_get_command_enter off > > trace-event qxl_interface_release_resource off > > trace-event qxl_interface_get_command_ret off > > trace-event qxl_push_free_res off > > Hmm, I'd suggest to just try find better names. These all are about > ring management (well, free_res is a bit special, but still ...), so maybe: > > qxl_ring_{command,cursor}_check (check whenever stuff is in there) > qxl_ring_{command,cursor}_get (take item out of the ring) > qxl_ring_res_put (stuff item into the ring) > > Then you can match them likewise easy with "qxl_ring_*", but you have > descriptive names without the IMHO ugly _freq suffix. Sounds good. > > cheers, > Gerd > >