From: Luiz Capitulino <lcapitulino@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/5] qxl-render: call ppm_save on bh
Date: Tue, 13 Mar 2012 10:22:42 -0300 [thread overview]
Message-ID: <20120313102242.759daf37@doriath.home> (raw)
In-Reply-To: <1331494004-26177-4-git-send-email-alevy@redhat.com>
On Sun, 11 Mar 2012 21:26:42 +0200
Alon Levy <alevy@redhat.com> wrote:
> With this change ppm_save is called after rendering, and not before.
> There are two lose ends:
> hmp: monitor will be active before ppm_save is complete.
The plan is to lock hmp's shell until rendering completes and the file is
saved. Looks ok to me.
> qmp: return will be emitted before ppm_save is complete.
Let see if I got this right, please correct me with I'm wrong:
o Before this commit: when screendump returns, there's an out of date
screendump file available in the FS
o After this commit: when screendump returns, there's no screendump
file available yet
There's a behavior change, which is better done via a new command, which
would need to be async and we don't support that today. Also, having an
out of date screendump is not exactly useful anyway.
Honestly, I don't know what's the best thing to do in this case, but I'll be
fine with it if Gerd acks this patch.
next prev parent reply other threads:[~2012-03-13 13:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 16:39 [Qemu-devel] [PATCH 0/4] fix qxl screendump using monitor_suspend Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 1/4] qxl: switch qxl.c to trace-events Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 2/4] qxl/qxl_render.c: add trace events Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 3/4] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump Alon Levy
2012-03-11 16:39 ` [Qemu-devel] [PATCH 4/4] qxl-render: call ppm_save on bh Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 0/5] fix qxl screendump using monitor_suspend Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 1/5] qxl: switch qxl.c to trace-events Alon Levy
2012-03-12 10:20 ` Gerd Hoffmann
2012-03-12 11:43 ` Alon Levy
2012-03-12 15:50 ` Alon Levy
2012-03-13 6:42 ` Gerd Hoffmann
2012-03-13 9:35 ` Alon Levy
2012-03-13 9:47 ` Gerd Hoffmann
2012-03-13 10:18 ` Alon Levy
2012-03-13 10:26 ` Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 2/5] qxl/qxl_render.c: add trace events Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 3/5] qxl-render: call ppm_save on bh Alon Levy
2012-03-13 13:22 ` Luiz Capitulino [this message]
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump Alon Levy
2012-03-13 13:35 ` Luiz Capitulino
2012-03-13 14:46 ` Alon Levy
2012-03-13 15:59 ` Luiz Capitulino
2012-03-13 17:35 ` Alon Levy
2012-03-13 18:07 ` Luiz Capitulino
2012-03-14 8:25 ` Gerd Hoffmann
2012-03-14 8:32 ` Alon Levy
2012-03-14 8:14 ` Gerd Hoffmann
2012-03-14 8:37 ` Daniel P. Berrange
2012-03-14 12:32 ` Luiz Capitulino
2012-03-14 13:14 ` Alon Levy
2012-03-14 13:17 ` Daniel P. Berrange
2012-03-14 13:18 ` Luiz Capitulino
2012-03-14 13:43 ` Alon Levy
2012-03-11 19:26 ` [Qemu-devel] [PATCH v2 5/5] qxl: screendump: use provided Monitor Alon Levy
2012-03-11 19:33 ` [Qemu-devel] [PATCH 0/4] fix qxl screendump using monitor_suspend Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313102242.759daf37@doriath.home \
--to=lcapitulino@redhat.com \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).