From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Rgh-00005v-42 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:22:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7RgW-0000Vo-DB for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:22:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7RgW-0000VR-50 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:22:40 -0400 Date: Tue, 13 Mar 2012 10:22:42 -0300 From: Luiz Capitulino Message-ID: <20120313102242.759daf37@doriath.home> In-Reply-To: <1331494004-26177-4-git-send-email-alevy@redhat.com> References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-4-git-send-email-alevy@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/5] qxl-render: call ppm_save on bh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com On Sun, 11 Mar 2012 21:26:42 +0200 Alon Levy wrote: > With this change ppm_save is called after rendering, and not before. > There are two lose ends: > hmp: monitor will be active before ppm_save is complete. The plan is to lock hmp's shell until rendering completes and the file is saved. Looks ok to me. > qmp: return will be emitted before ppm_save is complete. Let see if I got this right, please correct me with I'm wrong: o Before this commit: when screendump returns, there's an out of date screendump file available in the FS o After this commit: when screendump returns, there's no screendump file available yet There's a behavior change, which is better done via a new command, which would need to be async and we don't support that today. Also, having an out of date screendump is not exactly useful anyway. Honestly, I don't know what's the best thing to do in this case, but I'll be fine with it if Gerd acks this patch.