qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, harsh@linux.vnet.ibm.com,
	aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 07/12] trace: [tracetool] Process the "disable" event property
Date: Tue, 13 Mar 2012 21:03:16 +0100	[thread overview]
Message-ID: <20120313200316.24179.57107.stgit@ginnungagap.bsc.es> (raw)
In-Reply-To: <20120313200235.24179.63987.stgit@ginnungagap.bsc.es>

Use different converters (depending on the 'disabled' property) regardless of
the output format.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
 scripts/tracetool.py |   20 +++++++++++---------
 1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index fa646bc..d7c04b4 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -290,6 +290,9 @@ def dtrace_d(events):
     print
     print '};'
 
+def dtrace_nop_d(events):
+    pass
+
 def dtrace_stp(events):
     for event in events:
         # Define prototype for probe arguments
@@ -311,6 +314,9 @@ probe %(probeprefix)s.%(name)s = process("%(binary)s").mark("%(name)s")
         print '}'
     print
 
+def dtrace_nop_stp(events):
+    pass
+
 def trace_stap_begin():
     print '/* This file is autogenerated by tracetool, do not edit. */'
 
@@ -334,6 +340,8 @@ converters = {
     'nop': {
         'h': nop_h,
         'c': nop_c,
+        'd': dtrace_nop_d,
+        'stap': dtrace_nop_stp,
     },
 
     'stderr': {
@@ -483,17 +491,11 @@ def main():
         if probeprefix == "":
             probeprefix = 'qemu.' + targettype + '.' + targetarch
 
-    disabled_events, enabled_events = [], []
-    for e in read_events(sys.stdin):
-        if 'disable' in e.properties:
-            disabled_events.append(e)
-        else:
-            enabled_events.append(e)
+    events = read_events(sys.stdin)
 
     trace_gen[output]['begin']()
-    if output == 'h': # disabled events
-        converters['nop'][output](disabled_events)
-    converters[backend][output](enabled_events)
+    converters[backend][output]([ e for e in events if 'disable' not in e.properties ])
+    converters['nop'][output]([ e for e in events if 'disable' in e.properties ])
     trace_gen[output]['end']()
 
 if __name__ == "__main__":

  parent reply	other threads:[~2012-03-13 20:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 20:02 [Qemu-devel] [PATCH 00/12] Rewrite tracetool using python Lluís Vilanova
2012-03-13 20:02 ` [Qemu-devel] [PATCH 01/12] Converting tracetool.sh to tracetool.py Lluís Vilanova
2012-03-19 16:51   ` Stefan Hajnoczi
2012-03-13 20:02 ` [Qemu-devel] [PATCH 02/12] trace: [tracetool] Remove unused 'sizestr' attribute in 'Event' Lluís Vilanova
2012-03-13 20:02 ` [Qemu-devel] [PATCH 03/12] trace: [tracetool] Do not rebuild event list in backend code Lluís Vilanova
2012-03-13 20:02 ` [Qemu-devel] [PATCH 04/12] trace: [tracetool] Simplify event line parsing Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 05/12] trace: [tracetool] Do not precompute the event number Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 06/12] trace: [tracetool] Add support for event properties Lluís Vilanova
2012-03-13 20:03 ` Lluís Vilanova [this message]
2012-03-13 20:03 ` [Qemu-devel] [PATCH 08/12] trace: [tracetool] Rewrite event argument parsing Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 09/12] trace: [tracetool] Make format-specific code optional and with access to events Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 10/12] trace: [tracetool] Automatically establish available backends and formats Lluís Vilanova
2012-03-20  9:22   ` Stefan Hajnoczi
2012-03-20 14:00     ` Lluís Vilanova
2012-03-20 16:33       ` Stefan Hajnoczi
2012-03-20 18:45         ` Lluís Vilanova
2012-03-21  9:29           ` Stefan Hajnoczi
2012-03-21 14:10             ` Lluís Vilanova
2012-03-22  8:07               ` Stefan Hajnoczi
2012-03-21 19:59             ` Lluís Vilanova
2012-03-21 21:22               ` Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 11/12] trace: Provide a per-event status define for conditional compilation Lluís Vilanova
2012-03-13 20:03 ` [Qemu-devel] [PATCH 12/12] trace: [tracetool] Add error-reporting functions Lluís Vilanova
2012-03-19 17:45   ` Stefan Hajnoczi
2012-03-20  9:24 ` [Qemu-devel] [PATCH 00/12] Rewrite tracetool using python Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313200316.24179.57107.stgit@ginnungagap.bsc.es \
    --to=vilanova@ac.upc.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=harsh@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).