Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

[Alon Levy <alevy@redhat.com>]

On Wed, Mar 14, 2012 at 09:25:29AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > ok, I'll take it. Note that I'm going to not send the qxl screendump
> > behavior changing patch again, I think all alternatives to a real async
> > screendump suck, including libvirt changes, and the current behavior of
> > giving an old screendump is good enough hopefully for the real users,
> > which are:
> 
> Agree here.
> 
> >  boxes - refreshing to get updated thumbnails for it's users - will have
> >   5 seconds old screenshot until async monitor commands land.
> >  autotest - I hope they don't compare image contents (that would be hard
> >   to do), otherwise it's just for logging sake, and so it will lag a
> >   little, too bad.
> 
> autotest has (used to have?) a install mode where it looked at the
> screen.  I think it isn't used any more these days and unattended
> install modes (kickstart etc.) of the guests are used instead.  But even
> when checking the screen content it should still work fine, just take a
> little longer because the screen shots are a bit behind.
> 

Right. Actually I thought about install mode and assumed it would break
it but you're right, it shouldn't.

> cheers,
>   Gerd
>