From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7lKX-0007dY-Jb for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7lJv-000347-5v for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:21:17 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:52411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7lJu-00031i-Tc for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:20:39 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Mar 2012 10:20:33 -0000 Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2EAKEwd2244810 for ; Wed, 14 Mar 2012 10:20:14 GMT Received: from d06av09.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2EAKEoV015895 for ; Wed, 14 Mar 2012 04:20:14 -0600 Date: Wed, 14 Mar 2012 10:20:13 +0000 From: Stefan Hajnoczi Message-ID: <20120314102013.GA21271@stefanha-thinkpad.localdomain> References: <1331662001-2733-1-git-send-email-alevy@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331662001-2733-1-git-send-email-alevy@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] qxl trace events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org, kraxel@redhat.com On Tue, Mar 13, 2012 at 08:06:39PM +0200, Alon Levy wrote: > This is split from the previous screendump change patchset, hence the v2. > > This is by no way complete but I think it is a good start, and frankly I'd like > to stop here right now. > > Changes from v1: > add qid prefix to all tracepoints (except vga update which makes no sense) > rename to ring where suggested (Gerd) > add some trace points to spice-display > drop enter/exit in favor of a single command (Gerd) > some sorting of the trace event list > > Alon Levy (2): > qxl: switch qxl.c to trace-events > qxl/qxl_render.c: add trace events > > hw/qxl-render.c | 13 ++--- > hw/qxl.c | 156 +++++++++++++++++++++++++--------------------------- > trace-events | 66 ++++++++++++++++++++++ > ui/spice-display.c | 13 ++++- > 4 files changed, 157 insertions(+), 91 deletions(-) Some of the trace events have >6 arguments, which is the limit for the 'simple' trace backend today. The limit may be lifted in the near future but it would still be nice to avoid using >6 arguments today. Stefan