qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qxl/qxl_render.c: add trace events
Date: Wed, 14 Mar 2012 12:58:59 +0200	[thread overview]
Message-ID: <20120314105859.GY27659@garlic.redhat.com> (raw)
In-Reply-To: <4F605F17.3090706@redhat.com>

On Wed, Mar 14, 2012 at 10:04:23AM +0100, Gerd Hoffmann wrote:
> > +# hw/qxl-render.c
> > +qxl_blit_guest_primary_initialized(void) ""
> > +qxl_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t bottom) "stride=%d [%d, %d, %d, %d]"
> > +qxl_guest_primary_resized(int32_t width, int32_t height, int32_t stride, int32_t bytes_pp, int32_t bits_pp) "%dx%d, stride %d, bpp %d, depth %d"
> > +qxl_render_update_area_done(void *cookie) "%p"
> 
> Consistently name them qxl_render_* too?  for easy glob matching?

OK, makes sense.

> 
> cheers,
>   Gerd
> 

  reply	other threads:[~2012-03-14 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 18:06 [Qemu-devel] [PATCH v2 0/2] qxl trace events Alon Levy
2012-03-13 18:06 ` [Qemu-devel] [PATCH v2 1/2] qxl: switch qxl.c to trace-events Alon Levy
2012-03-14  9:03   ` Gerd Hoffmann
2012-03-14 10:58     ` Alon Levy
2012-03-13 18:06 ` [Qemu-devel] [PATCH v2 2/2] qxl/qxl_render.c: add trace events Alon Levy
2012-03-14  9:04   ` Gerd Hoffmann
2012-03-14 10:58     ` Alon Levy [this message]
2012-03-14 10:20 ` [Qemu-devel] [PATCH v2 0/2] qxl " Stefan Hajnoczi
2012-03-14 10:59   ` Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120314105859.GY27659@garlic.redhat.com \
    --to=alevy@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).