From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7lvH-0006eN-Re
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:59:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7lvA-0003w1-Mf
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:59:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7lvA-0003vn-Fo
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:59:08 -0400
Date: Wed, 14 Mar 2012 12:58:59 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120314105859.GY27659@garlic.redhat.com>
References: <1331662001-2733-1-git-send-email-alevy@redhat.com>
	<1331662001-2733-3-git-send-email-alevy@redhat.com>
	<4F605F17.3090706@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F605F17.3090706@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qxl/qxl_render.c: add trace events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Wed, Mar 14, 2012 at 10:04:23AM +0100, Gerd Hoffmann wrote:
> > +# hw/qxl-render.c
> > +qxl_blit_guest_primary_initialized(void) ""
> > +qxl_blit(int32_t stride, int32_t left, int32_t right, int32_t top, int32_t bottom) "stride=%d [%d, %d, %d, %d]"
> > +qxl_guest_primary_resized(int32_t width, int32_t height, int32_t stride, int32_t bytes_pp, int32_t bits_pp) "%dx%d, stride %d, bpp %d, depth %d"
> > +qxl_render_update_area_done(void *cookie) "%p"
> 
> Consistently name them qxl_render_* too?  for easy glob matching?

OK, makes sense.

> 
> cheers,
>   Gerd
>