From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1S7lw4-0000O0-DB
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 07:00:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1S7lvk-00043v-3D
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 07:00:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16615)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1S7lvj-00043h-SM
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:59:44 -0400
Date: Wed, 14 Mar 2012 12:59:36 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20120314105936.GX2304@redhat.com>
References: <4F5DD0FD.9070904@redhat.com> <20120313091843.GB3800@redhat.com>
	<4F5F25BF.7060100@redhat.com> <4F6056FE.3020202@cn.fujitsu.com>
	<4F6063C8.8010005@redhat.com> <4F606A7C.9090900@cn.fujitsu.com>
	<20120314103755.GD2708@amit.redhat.com>
	<4F607857.50402@cn.fujitsu.com> <4F60788A.2070608@redhat.com>
	<4F6079E7.7010608@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F6079E7.7010608@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: kvm list <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, Amit Shah <amit.shah@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

On Wed, Mar 14, 2012 at 06:58:47PM +0800, Wen Congyang wrote:
> At 03/14/2012 06:52 PM, Avi Kivity Wrote:
> > On 03/14/2012 12:52 PM, Wen Congyang wrote:
> >>>
> >>>> If so, is this channel visible to guest userspace? If the channle is visible to guest
> >>>> userspace, the program running in userspace may write the same message to the channel.
> >>>
> >>> Access control is via permissions.  You can have udev scripts assign
> >>> whatever uid and gid to the port of your interest.  By default, all
> >>> ports are only accessible to the root user.
> >>
> >> We should also prevent root user writing message to this channel if it is
> >> used for panicked notification.
> >>
> > 
> > Why?  root can easily cause a panic.
> > 
> 
> root user can write the same message to virtio-serial while the guest is running...
> 
So what?

--
			Gleb.