From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7ryo-0006Z2-H1 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7ryP-0004tA-LU for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:27:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7ryP-0004sV-DF for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:26:53 -0400 Date: Wed, 14 Mar 2012 14:26:48 -0300 From: Luiz Capitulino Message-ID: <20120314142648.6b0805dc@doriath.home> In-Reply-To: <4F5FFC63.3060300@cn.fujitsu.com> References: <4F5FFC63.3060300@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Jan Kiszka , qemu-devel , HATAYAMA Daisuke , Dave Anderson , Anthony Liguori , Eric Blake On Wed, 14 Mar 2012 10:03:15 +0800 Wen Congyang wrote: > Changes from v8 to v9: > 1. remove async support(it will be reimplemented after QAPI async commands support > is finished) I gave my review on this one (concentrating on the QMP part only), and one important aspect of this command is that it's a long synchronous operation. As it runs with vCPUs stopped, the only drawback is that libvirt won't be able to run other commands in parallel and won't be able to cancel it either. Also note that this command is most likely to be executed when the guest crashes. Given all this, it's fine with me to have this as a synchronous command, but I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.