From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7sYT-0006DM-4V for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7sYL-00056K-ND for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:04:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7sYL-00056A-FH for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:04:01 -0400 Date: Wed, 14 Mar 2012 15:03:56 -0300 From: Luiz Capitulino Message-ID: <20120314150356.1f3ec08c@doriath.home> In-Reply-To: <4F60DA47.50901@codemonkey.ws> References: <4F5FFC63.3060300@cn.fujitsu.com> <20120314142648.6b0805dc@doriath.home> <4F60DA47.50901@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , qemu-devel , HATAYAMA Daisuke , Dave Anderson , Eric Blake On Wed, 14 Mar 2012 12:49:59 -0500 Anthony Liguori wrote: > On 03/14/2012 12:26 PM, Luiz Capitulino wrote: > > On Wed, 14 Mar 2012 10:03:15 +0800 > > Wen Congyang wrote: > > > >> Changes from v8 to v9: > >> 1. remove async support(it will be reimplemented after QAPI async commands support > >> is finished) > > > > I gave my review on this one (concentrating on the QMP part only), and one > > important aspect of this command is that it's a long synchronous operation. > > > > As it runs with vCPUs stopped, the only drawback is that libvirt won't be able > > to run other commands in parallel and won't be able to cancel it either. Also > > note that this command is most likely to be executed when the guest crashes. > > > > Given all this, it's fine with me to have this as a synchronous command, but > > I'd like to get an ACK from libvirt and another one from Jan and/or Anthony. > > Just a general comment. > > Why is this an RFC if it's at v9? RFC's are never added to my review queue so I > haven't looked at this series at all. > > Can we start by posting a non-RFC because we start discussing committing this. Ah, I noticed that too but forgot asking Wen to do that for the next version. But the way I'm interpreting this is that it's a small mistake and he intended to get the series reviewed and committed.