From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7u2V-0000JT-8D
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:39:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7u28-0002Jc-5h
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:39:14 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:41409)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7u27-0002HC-V1
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:38:52 -0400
Received: by yenr5 with SMTP id r5so2519209yen.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 12:38:49 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 14 Mar 2012 14:38:43 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120314193843.GF2894@illuin>
References: <4F609652.9070701@gmail.com> <20120314185747.GD2894@illuin>
	<20120314190615.GE2894@illuin>
	<CABtrw+McEh2MUHNB8x_YGTQHOQ4DoM8aLkw8jO0p-XhvM6T9ww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABtrw+McEh2MUHNB8x_YGTQHOQ4DoM8aLkw8jO0p-XhvM6T9ww@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system
 registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Starikovskiy <aystarik@gmail.com>
Cc: qemu-devel@nongnu.org

On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote:
> Do I need to do anything beside following or not?

Not sure, ARM folks?

My suggestion would be to lose the the catch-all -EINVAL error we
throw in machine.c:cpu_load() when version_id != CPU_SAVE_VERSION
and only conditionally load 64-bit registers if the source's
version_id >= CPU_SAVE_VERSION. But we've never done that in the
past, and we broke old->new as recently as 2 months ago so I'm not
sure it's worth it since there hasn't been a release since then.

> 
> Thanks,
> Alex.
> 
> On Wed, Mar 14, 2012 at 11:06 PM, Michael Roth
> <mdroth@linux.vnet.ibm.com> wrote:
> >> > -#define CPU_SAVE_VERSION 6
> >> > +#define CPU_SAVE_VERSION 7
>