qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: agraf@suse.de, qemu-devel@nongnu.org, lcapitulino@redhat.com,
	qemu@buildbot.b1-systems.de,
	Anthony Liguori <anthony@codemonkey.ws>,
	gollub@b1-systems.de
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_s390
Date: Wed, 14 Mar 2012 19:11:54 -0500	[thread overview]
Message-ID: <20120315001154.GH2894@illuin> (raw)
In-Reply-To: <4F613140.60603@suse.de>

On Thu, Mar 15, 2012 at 01:01:04AM +0100, Andreas Färber wrote:
> Am 15.03.2012 01:16, schrieb qemu@buildbot.b1-systems.de:
> > The Buildbot has detected a new failure on builder default_s390 while building qemu.
> > Full details are available at:
> >  http://buildbot.b1-systems.de/qemu/builders/default_s390/builds/190
> > 
> > Buildbot URL: http://buildbot.b1-systems.de/qemu/
> > 
> > Buildslave for this Build: qemu-s390.opensuse.org
> > 
> > Build Reason: The Nightly scheduler named 'nightly_default' triggered this build
> > Build Source Stamp: [branch master] HEAD
> > Blamelist: 
> > 
> > BUILD FAILED: failed compile
> 
> Sorry...
> 
>   CC    lm32-softmmu/arch_init.o
> In file included from /home/build/qemu/default_s390/build/qemu-common.h:123,
>                  from /home/build/qemu/default_s390/build/monitor.h:4,
>                  from /home/build/qemu/default_s390/build/arch_init.c:32:
> /home/build/qemu/default_s390/build/target-lm32/cpu.h:185: error:
> redefinition of typedef 'CPULM32State'
> /home/build/qemu/default_s390/build/target-lm32/cpu.h:31: error:
> previous declaration of 'CPULM32State' was here
> make[1]: *** [arch_init.o] Error 1
> make: *** [subdir-lm32-softmmu] Error 2
> 
> My GCC handles the following code fine:
> 
> typedef struct CPULM32State CPULM32State;
> 
> typedef struct CPULM32State {
>     // ...
> } CPULM32State;
> 
> Solutions would be to
> a) drop the second typedef,
> b) use struct CPULM32State,
> c) move the function using it to after the second typedef.

I vote for a)

Multiple/unecessary typedefs is funky.

> 
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
> 

  reply	other threads:[~2012-03-15  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  0:16 [Qemu-devel] buildbot failure in qemu on default_s390 qemu
2012-03-15  0:01 ` Andreas Färber
2012-03-15  0:11   ` Michael Roth [this message]
2012-03-15  8:32     ` Alexander Graf
2012-03-15  9:16       ` Andreas Färber
  -- strict thread matches above, loose matches on Subject: below --
2012-05-14 23:57 qemu
2012-03-25  0:03 qemu
2012-01-24  0:09 qemu
2011-10-26  9:16 qemu
2011-10-30 16:42 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315001154.GH2894@illuin \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=gollub@b1-systems.de \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu@buildbot.b1-systems.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).