From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7yIW-0005ZV-Lc
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 20:12:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7yIU-0003jO-Lh
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 20:12:04 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:55775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S7yIU-0003jK-El
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 20:12:02 -0400
Received: by ghrr14 with SMTP id r14so2829624ghr.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 17:12:00 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 14 Mar 2012 19:11:54 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120315001154.GH2894@illuin>
References: <20120315001604.8FAA94010F@buildbot.b1-systems.de>
	<4F613140.60603@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4F613140.60603@suse.de>
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_s390
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: agraf@suse.de, qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu@buildbot.b1-systems.de, Anthony Liguori <anthony@codemonkey.ws>, gollub@b1-systems.de

On Thu, Mar 15, 2012 at 01:01:04AM +0100, Andreas Färber wrote:
> Am 15.03.2012 01:16, schrieb qemu@buildbot.b1-systems.de:
> > The Buildbot has detected a new failure on builder default_s390 while building qemu.
> > Full details are available at:
> >  http://buildbot.b1-systems.de/qemu/builders/default_s390/builds/190
> > 
> > Buildbot URL: http://buildbot.b1-systems.de/qemu/
> > 
> > Buildslave for this Build: qemu-s390.opensuse.org
> > 
> > Build Reason: The Nightly scheduler named 'nightly_default' triggered this build
> > Build Source Stamp: [branch master] HEAD
> > Blamelist: 
> > 
> > BUILD FAILED: failed compile
> 
> Sorry...
> 
>   CC    lm32-softmmu/arch_init.o
> In file included from /home/build/qemu/default_s390/build/qemu-common.h:123,
>                  from /home/build/qemu/default_s390/build/monitor.h:4,
>                  from /home/build/qemu/default_s390/build/arch_init.c:32:
> /home/build/qemu/default_s390/build/target-lm32/cpu.h:185: error:
> redefinition of typedef 'CPULM32State'
> /home/build/qemu/default_s390/build/target-lm32/cpu.h:31: error:
> previous declaration of 'CPULM32State' was here
> make[1]: *** [arch_init.o] Error 1
> make: *** [subdir-lm32-softmmu] Error 2
> 
> My GCC handles the following code fine:
> 
> typedef struct CPULM32State CPULM32State;
> 
> typedef struct CPULM32State {
>     // ...
> } CPULM32State;
> 
> Solutions would be to
> a) drop the second typedef,
> b) use struct CPULM32State,
> c) move the function using it to after the second typedef.

I vote for a)

Multiple/unecessary typedefs is funky.

> 
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>