* [Qemu-devel] [RFC] qemu-iotest only for Linux?
@ 2012-03-14 22:04 Stefan Weil
2012-03-15 7:59 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2012-03-14 22:04 UTC (permalink / raw)
To: Christoph Hellwig, Kevin Wolf, Stefan Hajnoczi; +Cc: QEMU Developers
Hi,
What's the reason for "_supported_os Linux" in each test?
Because of this statement, the tests only run on Linux today,
although they could also run on BSD, w32 and other operating
systems (maybe small fixes are needed).
I don't think that adding every possible OS to each test
would be a good solution. Can we remove this OS dependency
completely?
Regards,
Stefan W.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [RFC] qemu-iotest only for Linux?
2012-03-14 22:04 [Qemu-devel] [RFC] qemu-iotest only for Linux? Stefan Weil
@ 2012-03-15 7:59 ` Stefan Hajnoczi
2012-03-15 9:16 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-03-15 7:59 UTC (permalink / raw)
To: Stefan Weil; +Cc: Kevin Wolf, Christoph Hellwig, QEMU Developers
On Wed, Mar 14, 2012 at 11:04:24PM +0100, Stefan Weil wrote:
> What's the reason for "_supported_os Linux" in each test?
> Because of this statement, the tests only run on Linux today,
> although they could also run on BSD, w32 and other operating
> systems (maybe small fixes are needed).
>
> I don't think that adding every possible OS to each test
> would be a good solution. Can we remove this OS dependency
> completely?
In many cases the _supported_os was probably copy-pasted when creating
new tests. However, we can be pretty sure that the tests haven't all
been run on anything other than Linux and maybe Windows recently.
I think we can support other host OSes but we should combine this with
adding "make check" and maybe "make check-block" to the buildbot - that
way we'll be notified if the tests break. There are Linux, Solaris, and
OpenBSD buildslaves.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [RFC] qemu-iotest only for Linux?
2012-03-15 7:59 ` Stefan Hajnoczi
@ 2012-03-15 9:16 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2012-03-15 9:16 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Stefan Weil, Christoph Hellwig, QEMU Developers
On Thu, Mar 15, 2012 at 07:59:20AM +0000, Stefan Hajnoczi wrote:
> On Wed, Mar 14, 2012 at 11:04:24PM +0100, Stefan Weil wrote:
> > What's the reason for "_supported_os Linux" in each test?
> > Because of this statement, the tests only run on Linux today,
> > although they could also run on BSD, w32 and other operating
> > systems (maybe small fixes are needed).
> >
> > I don't think that adding every possible OS to each test
> > would be a good solution. Can we remove this OS dependency
> > completely?
>
> In many cases the _supported_os was probably copy-pasted when creating
> new tests. However, we can be pretty sure that the tests haven't all
> been run on anything other than Linux and maybe Windows recently.
Yes.
> I think we can support other host OSes but we should combine this with
> adding "make check" and maybe "make check-block" to the buildbot - that
> way we'll be notified if the tests break. There are Linux, Solaris, and
> OpenBSD buildslaves.
For now please add the Oses it actually works as documentation, once
we have a good overview we can add classes like "generic" or "posix"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-15 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 22:04 [Qemu-devel] [RFC] qemu-iotest only for Linux? Stefan Weil
2012-03-15 7:59 ` Stefan Hajnoczi
2012-03-15 9:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).