From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S8BdB-0008GM-Nm
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 10:26:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S8Bcq-000152-2c
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 10:26:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S8Bcp-00014s-Q9
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 10:25:55 -0400
Date: Thu, 15 Mar 2012 11:25:51 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120315112551.7bb09a46@doriath.home>
In-Reply-To: <20120314141847.4557b4bb@doriath.home>
References: <4F5FFC63.3060300@cn.fujitsu.com> <4F5FFE57.8010308@cn.fujitsu.com>
	<20120314141847.4557b4bb@doriath.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor
 command 'dump' to dump guest's memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>

On Wed, 14 Mar 2012 14:18:47 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> > +    ret = write(fd, buf, size);
> > +    if (ret != size) {
> > +        return -1;
> > +    }  
> 
> I think you should use send_all() instead of plain write().

Missed the fact that we actually have qemu_write_full().