From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img
Date: Thu, 15 Mar 2012 12:45:24 +0000 [thread overview]
Message-ID: <20120315124524.GA6111@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1331813614-3754-1-git-send-email-wdongxu@linux.vnet.ibm.com>
On Thu, Mar 15, 2012 at 08:13:31PM +0800, Dong Xu Wang wrote:
> From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>
> Discussion can be found at:
> http://patchwork.ozlabs.org/patch/128730/
>
> This patch add image fragmentation statistics while using qemu-img check.
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
> block.h | 7 +++++++
> qemu-img.c | 9 ++++++++-
> 2 files changed, 15 insertions(+), 1 deletions(-)
A minor comment that doesn't require resending:
Please avoid introducing whitespace or reformatting changes in a patch
that makes other code changes. Patch 1 changes whitespace in a place
that is not touched by the rest of your patch, so that change is not
essential and it's best to leave it out.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2012-03-15 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 12:13 [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img Dong Xu Wang
2012-03-15 12:13 ` [Qemu-devel] [PATCH 2/4 v3] block: image fragmentation statistics for qed Dong Xu Wang
2012-03-15 12:13 ` [Qemu-devel] [PATCH 3/4 v3] block: add dirty flag status to qemu-img Dong Xu Wang
2012-03-15 12:13 ` [Qemu-devel] [PATCH 4/4] block: track dirty flag status in qed Dong Xu Wang
2012-03-15 12:45 ` Stefan Hajnoczi [this message]
2012-03-29 15:56 ` [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img Stefan Hajnoczi
2012-03-29 16:00 ` Stefan Hajnoczi
2012-04-02 16:13 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2012-03-15 12:47 Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315124524.GA6111@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).