From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8A4N-0007DT-Gf for qemu-devel@nongnu.org; Thu, 15 Mar 2012 08:46:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8A4E-0000D1-FN for qemu-devel@nongnu.org; Thu, 15 Mar 2012 08:46:15 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:59793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8A4E-0000BJ-6l for qemu-devel@nongnu.org; Thu, 15 Mar 2012 08:46:06 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Mar 2012 12:45:39 -0000 Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2FCjPVu2179182 for ; Thu, 15 Mar 2012 12:45:25 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2FCjPXl024129 for ; Thu, 15 Mar 2012 06:45:25 -0600 Date: Thu, 15 Mar 2012 12:45:24 +0000 From: Stefan Hajnoczi Message-ID: <20120315124524.GA6111@stefanha-thinkpad.localdomain> References: <1331813614-3754-1-git-send-email-wdongxu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331813614-3754-1-git-send-email-wdongxu@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/4 v3] block: add image fragmentation statistics to qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Thu, Mar 15, 2012 at 08:13:31PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > Discussion can be found at: > http://patchwork.ozlabs.org/patch/128730/ > > This patch add image fragmentation statistics while using qemu-img check. > > Signed-off-by: Dong Xu Wang > --- > block.h | 7 +++++++ > qemu-img.c | 9 ++++++++- > 2 files changed, 15 insertions(+), 1 deletions(-) A minor comment that doesn't require resending: Please avoid introducing whitespace or reformatting changes in a patch that makes other code changes. Patch 1 changes whitespace in a place that is not touched by the rest of your patch, so that change is not essential and it's best to leave it out. Reviewed-by: Stefan Hajnoczi