From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9XxP-0007hZ-3Y for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9XxN-00084f-EJ for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:28:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9XxN-00084J-62 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:28:45 -0400 Date: Mon, 19 Mar 2012 10:28:40 +0200 From: Gleb Natapov Message-ID: <20120319082840.GL27306@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/2] acpi: robust notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , qemu-devel@nongnu.org, Anthony Liguori On Sun, Mar 18, 2012 at 07:06:23PM +0200, Michael S. Tsirkin wrote: > acpi currently clears up/down registers on each hotplug > request. This loses events if they are done quickly. > It's easy to clear down on ej write. > To detect that guest was notified of device addition, > we track configuration accesses since system reset. > This is hack. This is not how real HW works, why do we needed it? If up/down thing is so broken that this is required lets move to how cpu hot-plug works and maintain slot status bit map instead. BTW we discussed that with Alex last week. Have you followed that thread. > Michael S. Tsirkin (2): > pci: track function accesses > acpi: don't clear up/down on each host change > > hw/acpi_piix4.c | 32 +++++++++++++++++++++++++++----- > hw/pci.c | 26 ++++++++++++++++++++++++++ > hw/pci.h | 3 +++ > hw/pci_host.c | 2 ++ > 4 files changed, 58 insertions(+), 5 deletions(-) > > -- > 1.7.9.111.gf3fb0 -- Gleb.