From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41963)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S9YHj-0004Cu-CK
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:49:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S9YHe-0003Gl-MU
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:49:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S9YHe-0003GY-Ei
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 04:49:42 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2J8nerS006297
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 19 Mar 2012 04:49:40 -0400
Date: Mon, 19 Mar 2012 09:49:35 +0100
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120319084935.GI6715@garlic.redhat.com>
References: <1332056559-8585-1-git-send-email-yhalperi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1332056559-8585-1-git-send-email-yhalperi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: fix client_migrate_info error
 handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

On Sun, Mar 18, 2012 at 09:42:39AM +0200, Yonit Halperin wrote:
> Report QERR_INVALID_PARAMETER when port is missing. Otherwise
> QERR_UNDEFINED_ERROR will occur.
> 
> rhbz #795652
> 

Reviewed-by: Alon Levy <alevy@redhat.com>

> Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
> ---
>  monitor.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index d57e7bf..8f46031 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -880,6 +880,11 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict,
>              return -1;
>          }
>  
> +        if (port == -1 && tls_port == -1) {
> +            qerror_report(QERR_MISSING_PARAMETER, "port/tls-port");
> +            return -1;
> +        }
> +
>          ret = qemu_spice_migrate_info(hostname, port, tls_port, subject,
>                                        cb, opaque);
>          if (ret != 0) {
> -- 
> 1.7.7.6
> 
>