qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] QOM: device_del core dumps qemu
@ 2012-03-19 20:20 Luiz Capitulino
  2012-03-19 20:22 ` Anthony Liguori
  0 siblings, 1 reply; 3+ messages in thread
From: Luiz Capitulino @ 2012-03-19 20:20 UTC (permalink / raw)
  To: qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori


# qemu [..] -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \
            -device virtio-net-pci,netdev=guest0,id=foo

The on the monitor:

(qemu) device_del foo
(qemu)

Bisect says it's caused by commit:

commit dd0ba250ca83ed915ea192ab7539cdbb4e868c14
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Feb 2 13:08:48 2012 +0100

    qdev: let QOM free properties
    
    Drop the special free callback.  Instead, register a "regular"
    release method in the non-legacy property.
    
    Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] QOM: device_del core dumps qemu
  2012-03-19 20:20 [Qemu-devel] QOM: device_del core dumps qemu Luiz Capitulino
@ 2012-03-19 20:22 ` Anthony Liguori
  2012-03-19 20:27   ` Luiz Capitulino
  0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2012-03-19 20:22 UTC (permalink / raw)
  To: Luiz Capitulino; +Cc: Paolo Bonzini, qemu-devel

On 03/19/2012 03:20 PM, Luiz Capitulino wrote:
>
> # qemu [..] -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \
>              -device virtio-net-pci,netdev=guest0,id=foo
>
> The on the monitor:
>
> (qemu) device_del foo
> (qemu)

Pretty sure this is fixed by:

commit e5ab1404d014cefe22e9a10fca00d0acf4fe412b
Author: Anthony Liguori <aliguori@us.ibm.com>
Date:   Thu Mar 15 11:29:56 2012 -0500

     pci: fix double free of romfile property

Which I just pushed earlier today.

Could you confirm that?

Regards,

Anthony Liguori

>
> Bisect says it's caused by commit:
>
> commit dd0ba250ca83ed915ea192ab7539cdbb4e868c14
> Author: Paolo Bonzini<pbonzini@redhat.com>
> Date:   Thu Feb 2 13:08:48 2012 +0100
>
>      qdev: let QOM free properties
>
>      Drop the special free callback.  Instead, register a "regular"
>      release method in the non-legacy property.
>
>      Reviewed-by: Anthony Liguori<aliguori@us.ibm.com>
>      Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] QOM: device_del core dumps qemu
  2012-03-19 20:22 ` Anthony Liguori
@ 2012-03-19 20:27   ` Luiz Capitulino
  0 siblings, 0 replies; 3+ messages in thread
From: Luiz Capitulino @ 2012-03-19 20:27 UTC (permalink / raw)
  To: Anthony Liguori; +Cc: Paolo Bonzini, qemu-devel

On Mon, 19 Mar 2012 15:22:34 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 03/19/2012 03:20 PM, Luiz Capitulino wrote:
> >
> > # qemu [..] -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \
> >              -device virtio-net-pci,netdev=guest0,id=foo
> >
> > The on the monitor:
> >
> > (qemu) device_del foo
> > (qemu)
> 
> Pretty sure this is fixed by:
> 
> commit e5ab1404d014cefe22e9a10fca00d0acf4fe412b
> Author: Anthony Liguori <aliguori@us.ibm.com>
> Date:   Thu Mar 15 11:29:56 2012 -0500
> 
>      pci: fix double free of romfile property
> 
> Which I just pushed earlier today.
> 
> Could you confirm that?

Confirmed, it fixes the bug to me, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-19 20:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19 20:20 [Qemu-devel] QOM: device_del core dumps qemu Luiz Capitulino
2012-03-19 20:22 ` Anthony Liguori
2012-03-19 20:27   ` Luiz Capitulino

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).