From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9vOi-0001Jk-2y for qemu-devel@nongnu.org; Tue, 20 Mar 2012 05:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9vOg-00083j-7b for qemu-devel@nongnu.org; Tue, 20 Mar 2012 05:30:31 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:58185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9vOf-00083Q-Ug for qemu-devel@nongnu.org; Tue, 20 Mar 2012 05:30:30 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Mar 2012 09:30:25 -0000 Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2K9UMm72523366 for ; Tue, 20 Mar 2012 09:30:24 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2K7Rd2F013260 for ; Tue, 20 Mar 2012 03:27:39 -0400 Date: Tue, 20 Mar 2012 09:30:21 +0000 From: Stefan Hajnoczi Message-ID: <20120320093021.GA5403@stefanha-thinkpad.localdomain> References: <1331845217-21705-1-git-send-email-mjt@msgid.tls.msk.ru> <1331845217-21705-5-git-send-email-mjt@msgid.tls.msk.ru> <4F6367F7.7040506@redhat.com> <20120319143613.GB19040@stefanha-thinkpad.localdomain> <4F679154.9080903@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F679154.9080903@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori On Tue, Mar 20, 2012 at 12:04:36AM +0400, Michael Tokarev wrote: > > I don't have bandwidth for non-trivial cosmetic stuff at the > > moment, sorry. > > What's "bandwidth" in this context? Time. My review queue is 120 patches at the moment. I'm tackling those which are blocked on me and which fix bugs/add features first. > Initially I thought that just making 2 or 3 functions which > were inconsistent with each other to be a very easy task. > But the patchset grew to 11 patches and 5 versions, because > pbonzini said it is insufficient. Now you're saying it is > too much. > > I spent *much* more than any sane amount of time on this, > rediffing and rewriting, on a *trivial* thing, and now what? > > If you can't plan even the most simple and low-level interface > to be consistent, please at least let someone who is STILL > willing to make it consistent to do that. It is not cosmetic. > And if the code will grow this way further (and it does!), > it will be a very big ball of mud, unmaintainable. I'm not blocking this series. If others are happy with this series then please merge. Stefan