From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA1I5-0001Bw-PE for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:48:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA1I0-00078C-BL for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:48:05 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:60811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA1I0-00077u-2J for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:48:00 -0400 Received: by werp12 with SMTP id p12so195017wer.4 for ; Tue, 20 Mar 2012 08:47:57 -0700 (PDT) Date: Tue, 20 Mar 2012 15:47:55 +0000 From: Stefan Hajnoczi Message-ID: <20120320154755.GB896@stefanha-thinkpad.localdomain> References: <1331055149-10982-1-git-send-email-benoit.canet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1331055149-10982-1-git-send-email-benoit.canet@gmail.com> Subject: Re: [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, wolf@redhat.com, stefanha@linux.vnet.ibm.com On Tue, Mar 06, 2012 at 06:32:19PM +0100, Benoît Canet wrote: > QED + live migration is an unsafe and disabled mix. > > This patchset make qed and live migration safe to use. > > The check of QED images is delayed during the incoming migration. > After the migration complete the QED images are checked. > > Benoît Canet (10): > block: Add new BDRV_O_INCOMING flag to notice incoming live migration > block: add a function to set incoming live migration > block: add a function to clear incoming live migration > block: rename *_invalidate_cache_* to *_post_incoming_migration_* > migration: inform the block layer of incoming live status > block: open images with BDRV_O_INCOMING on incoming live migration > qed: extract image checking into check_image_if_needed > qed: add bdrv_post_incoming_migration operation checking the image > qed: honor BDRV_O_INCOMING for incoming live migration > qed: remove incoming live migration blocker > > block.c | 35 +++++++++++++++++++++--- > block.h | 13 +++++++-- > block/qcow2.c | 7 ++++- > block/qed.c | 81 +++++++++++++++++++++++++++++++++++---------------------- > block/qed.h | 2 - > block_int.h | 4 +- > migration.c | 9 +++++- > vl.c | 5 +++ > 8 files changed, 110 insertions(+), 46 deletions(-) We talked about image format live migration approaches on IRC today with Kevin. I think the approach you have here will do the job. Stefan