From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2dT-000665-Lu for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:14:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2dR-0007OY-V0 for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:14:15 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:52746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2dR-0007OL-PL for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:14:13 -0400 From: Paul Brook Date: Tue, 20 Mar 2012 17:14:08 +0000 References: <201203201408.56275.paul@codesourcery.com> <4F68B6AA.7060803@codemonkey.ws> In-Reply-To: <4F68B6AA.7060803@codemonkey.ws> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201203201714.09024.paul@codesourcery.com> Subject: Re: [Qemu-devel] ARM QOM conversion / class hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , QEMU Developers , Andreas =?utf-8?q?F=C3=A4rber?= > Make an ARMCPUClass that maps to the existing ARM support. Do *not* expose > all of the different features as properties. Make ARMCPUClass abstract. > > Subclass ARMCPUClass for specific models, set default flags to implement > the necessary logic. Expose tunables on a case-by-case basis (if there > needs to be a 'neon' flag for cortex-a9, then make one, but don't make > everything a flag just for the hell of it). As long as we can avoid the sort of duplication and redundant implementation that the initial .feature patch introduced. If only having a neon knob on some cores means we have to duplicate a whole bunch of boilerplate between those cores then we're doing it wrong. Paul