From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only
Date: Tue, 20 Mar 2012 19:47:46 -0500 [thread overview]
Message-ID: <20120321004746.GA18965@illuin> (raw)
In-Reply-To: <20120320181925.GA32325@illuin>
On Tue, Mar 20, 2012 at 01:19:25PM -0500, Michael Roth wrote:
> On Tue, Mar 20, 2012 at 05:16:41PM +0100, Michal Privoznik wrote:
> > On 20.03.2012 17:10, Michael Roth wrote:
> > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote:
> > >> Currently, the implementation of that command is full of
> > >> Linux specific code. Before any brave man will step into
> > >> and port it to other OSes, make this function Linux only.
> > >>
> > >> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > >
> > > Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to
> > > be available on BSD and OpenSolaris, and we're already stubbed for w32.
> > > Are you seeing breakage?
> >
> > Personally, I don't; but there has been this report:
> >
> > http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03951.html
> >
> > which happens on OpenBSD, I suspect.
>
> Ew, okay, well it looks like guest-suspend has a role as well so this
> patch wouldn't be sufficient. Let me fire up a FreeBSD image I have
> laying around and play around with it a bit.
>
Bleh.. hit a gcc bug on the build then ran out of disk space trying to
upgrade to the latest gcc. Let's stub guest-network* and guest-suspend*
for now. I'll send a patch for the guest-suspend side and to get rid
of the warnings.
> >
> > Michal
> >
next prev parent reply other threads:[~2012-03-21 0:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 15:09 [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only Michal Privoznik
2012-03-20 16:10 ` Michael Roth
2012-03-20 16:16 ` Michal Privoznik
2012-03-20 18:19 ` Michael Roth
2012-03-21 0:47 ` Michael Roth [this message]
2012-03-26 16:35 ` Andreas Färber
2012-03-26 18:47 ` Michael Roth
2012-03-21 0:54 ` [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux Michael Roth
2012-03-23 18:20 ` Luiz Capitulino
2012-03-23 19:11 ` Michael Roth
2012-03-23 20:37 ` Luiz Capitulino
2012-03-25 19:40 ` [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations Michael Roth
2012-03-26 16:22 ` Luiz Capitulino
2012-03-26 20:24 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321004746.GA18965@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).