From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA9iW-0006Ke-Nn for qemu-devel@nongnu.org; Tue, 20 Mar 2012 20:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA9iU-000703-Tt for qemu-devel@nongnu.org; Tue, 20 Mar 2012 20:47:56 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:50870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA9iU-0006zk-H3 for qemu-devel@nongnu.org; Tue, 20 Mar 2012 20:47:54 -0400 Received: by iafj26 with SMTP id j26so862348iaf.4 for ; Tue, 20 Mar 2012 17:47:52 -0700 (PDT) Sender: fluxion Date: Tue, 20 Mar 2012 19:47:46 -0500 From: Michael Roth Message-ID: <20120321004746.GA18965@illuin> References: <0ccd5fa1764f254dbde6851c0d2139e9198a25e2.1332256180.git.mprivozn@redhat.com> <20120320161046.GA29058@illuin> <4F68AD69.8060500@redhat.com> <20120320181925.GA32325@illuin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120320181925.GA32325@illuin> Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: qemu-devel@nongnu.org On Tue, Mar 20, 2012 at 01:19:25PM -0500, Michael Roth wrote: > On Tue, Mar 20, 2012 at 05:16:41PM +0100, Michal Privoznik wrote: > > On 20.03.2012 17:10, Michael Roth wrote: > > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: > > >> Currently, the implementation of that command is full of > > >> Linux specific code. Before any brave man will step into > > >> and port it to other OSes, make this function Linux only. > > >> > > >> Signed-off-by: Michal Privoznik > > > > > > Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to > > > be available on BSD and OpenSolaris, and we're already stubbed for w32. > > > Are you seeing breakage? > > > > Personally, I don't; but there has been this report: > > > > http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03951.html > > > > which happens on OpenBSD, I suspect. > > Ew, okay, well it looks like guest-suspend has a role as well so this > patch wouldn't be sufficient. Let me fire up a FreeBSD image I have > laying around and play around with it a bit. > Bleh.. hit a gcc bug on the build then ran out of disk space trying to upgrade to the latest gcc. Let's stub guest-network* and guest-suspend* for now. I'll send a patch for the guest-suspend side and to get rid of the warnings. > > > > Michal > >