From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAL8Z-0002Nw-JT for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAL8X-0004ty-OC for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:59:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAL8X-0004tp-GA for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:59:33 -0400 Date: Wed, 21 Mar 2012 14:59:00 +0200 From: "Michael S. Tsirkin" Message-ID: <20120321125858.GA21467@redhat.com> References: <1330479314.29508.7.camel@nzhmlwks0057.ad.endace.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330479314.29508.7.camel@nzhmlwks0057.ad.endace.com> Subject: Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Korolev Cc: "qemu-devel@nongnu.org" On Wed, Feb 29, 2012 at 02:35:14PM +1300, Alexey Korolev wrote: > Hi, > > There is a typo in i440FX init code. This is causing problems when > somebody wants to access 64bit PCI range. > > > Signed-off-by: Alexey Korolev I've fixed the commit message and applied. How does one trigger the problem? I'd like to know so I can test for it. > --- > > hw/piix_pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 3ed3d90..aab8188 100644 > --- a/hw/piix_pci.c > +++ b/hw/piix_pci.c > @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn, > b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, pic, > address_space_mem, address_space_io, ram_size, > pci_hole_start, pci_hole_size, > - pci_hole64_size, pci_hole64_size, > + pci_hole64_start, pci_hole64_size, > pci_memory, ram_memory); > return b; > } > > > >