From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference
Date: Wed, 21 Mar 2012 10:06:23 -0500 [thread overview]
Message-ID: <20120321150623.GB18965@illuin> (raw)
In-Reply-To: <CAJSP0QXFP-M-d0yX91qY-3--YNse=O=kvRhytZ=+3hmgyuD4AQ@mail.gmail.com>
On Wed, Mar 21, 2012 at 11:37:10AM +0000, Stefan Hajnoczi wrote:
> On Tue, Mar 20, 2012 at 12:18 AM, Michael Roth
> <mdroth@linux.vnet.ibm.com> wrote:
> > This was added by mistake a while back.
> >
> > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> > ---
> > tests/Makefile | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> After applying your series and rebuilding, I get the following error.
> I checked that there are no auto-generated files left around after
> make distclean.
Shoot, sorry, I must've only tested make check after the change. It looks
like qemu-ga target is relying on that dependency being sourced from
tests/Makefile. I'll send an updated 1/3 that moves it to top-level
Makefile where it should be.
>
> $ make distclean
> $ ./configure --target-list=x86_64-softmmu --disable-werror
> $ make
> GEN x86_64-softmmu/config-devices.mak
> GEN config-all-devices.mak
> GEN qemu-options.texi
> GEN qemu-monitor.texi
> GEN qemu-img-cmds.texi
> GEN qemu-doc.html
> GEN qemu-tech.html
> GEN qemu.1
> GEN qemu-img.1
> GEN qemu-nbd.8
> GEN QMP/qmp-commands.txt
> GEN config-host.h
> GEN trace.h
> GEN qemu-options.def
> GEN qmp-commands.h
> GEN qapi-types.h
> GEN qapi-visit.h
> GEN /home/stefanha/qemu/qapi-generated/qga-qapi-types.h
> GEN /home/stefanha/qemu/qapi-generated/qga-qapi-visit.h
> GEN /home/stefanha/qemu/qapi-generated/qga-qmp-commands.h
> CC qemu-ga.o
> CC qga/commands.o
> qga/commands.c:15:30: fatal error: qga-qmp-commands.h: No such file or directory
> compilation terminated.
> make: *** [qga/commands.o] Error 1
>
next prev parent reply other threads:[~2012-03-21 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 0:18 [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference Michael Roth
2012-03-20 0:18 ` [Qemu-devel] [PATCH 2/3] qapi: remove print statements from test-qmp-commands Michael Roth
2012-03-20 0:18 ` [Qemu-devel] [PATCH 3/3] test: add test-qmp-commands to make check Michael Roth
2012-03-21 11:37 ` [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference Stefan Hajnoczi
2012-03-21 15:06 ` Michael Roth [this message]
2012-03-21 15:10 ` [Qemu-devel] [PATCH v2] " Michael Roth
2012-03-22 8:14 ` Stefan Hajnoczi
2012-03-26 20:07 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321150623.GB18965@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).