From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SAN7Q-00022i-GK
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 11:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SAN7O-0001cF-HF
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 11:06:32 -0400
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 21 Mar 2012 10:06:23 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120321150623.GB18965@illuin>
References: <1332202706-25061-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<CAJSP0QXFP-M-d0yX91qY-3--YNse=O=kvRhytZ=+3hmgyuD4AQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJSP0QXFP-M-d0yX91qY-3--YNse=O=kvRhytZ=+3hmgyuD4AQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org

On Wed, Mar 21, 2012 at 11:37:10AM +0000, Stefan Hajnoczi wrote:
> On Tue, Mar 20, 2012 at 12:18 AM, Michael Roth
> <mdroth@linux.vnet.ibm.com> wrote:
> > This was added by mistake a while back.
> >
> > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> > ---
> >  tests/Makefile |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> After applying your series and rebuilding, I get the following error.
> I checked that there are no auto-generated files left around after
> make distclean.

Shoot, sorry, I must've only tested make check after the change. It looks
like qemu-ga target is relying on that dependency being sourced from
tests/Makefile. I'll send an updated 1/3 that moves it to top-level
Makefile where it should be.

> 
> $ make distclean
> $ ./configure --target-list=x86_64-softmmu --disable-werror
> $ make
>   GEN   x86_64-softmmu/config-devices.mak
>   GEN   config-all-devices.mak
>   GEN   qemu-options.texi
>   GEN   qemu-monitor.texi
>   GEN   qemu-img-cmds.texi
>   GEN   qemu-doc.html
>   GEN   qemu-tech.html
>   GEN   qemu.1
>   GEN   qemu-img.1
>   GEN   qemu-nbd.8
>   GEN   QMP/qmp-commands.txt
>   GEN   config-host.h
>   GEN   trace.h
>   GEN   qemu-options.def
>   GEN   qmp-commands.h
>   GEN   qapi-types.h
>   GEN   qapi-visit.h
>   GEN   /home/stefanha/qemu/qapi-generated/qga-qapi-types.h
>   GEN   /home/stefanha/qemu/qapi-generated/qga-qapi-visit.h
>   GEN   /home/stefanha/qemu/qapi-generated/qga-qmp-commands.h
>   CC    qemu-ga.o
>   CC    qga/commands.o
> qga/commands.c:15:30: fatal error: qga-qmp-commands.h: No such file or directory
> compilation terminated.
> make: *** [qga/commands.o] Error 1
>