From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SASTD-0005VU-90
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 16:49:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SASTB-0002ec-FT
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 16:49:22 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:60228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SASTB-0002eW-8X
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 16:49:21 -0400
Received: by obbwd20 with SMTP id wd20so1063783obb.4
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2012 13:49:19 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 21 Mar 2012 15:49:14 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120321204914.GD18965@illuin>
References: <cover.1332197811.git.quintela@redhat.com>
	<910e3e55f31b589636de54796e84c0c43453aa18.1332197811.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <910e3e55f31b589636de54796e84c0c43453aa18.1332197811.git.quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 03/36] vmstate: unicore32 don't support cpu
 migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Mar 19, 2012 at 11:57:31PM +0100, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  target-unicore32/cpu.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h
> index a3f8589..be85250 100644
> --- a/target-unicore32/cpu.h
> +++ b/target-unicore32/cpu.h
> @@ -134,8 +134,6 @@ int uc32_cpu_signal_handler(int host_signum, void *pinfo, void *puc);
>  int uc32_cpu_handle_mmu_fault(CPUUniCore32State *env, target_ulong address, int rw,
>                                int mmu_idx);
> 
> -#define CPU_SAVE_VERSION 2
> -

Would it be pretty straightforward to give this the same treatment as
the cpus in #2? Would be nice to have a migration blocker registered
rather than just continuing to allow users to try it hopelessly.

>  /* MMU modes definitions */
>  #define MMU_MODE0_SUFFIX _kernel
>  #define MMU_MODE1_SUFFIX _user
> -- 
> 1.7.7.6
> 
>